620950 - nsImageMap::AddArea could set area to 0 in default NS_NOTREACHED case

Status: NEW

(Core :: Layout: Images, Video, and HTML Frames, enhancement)

Description

[timeless]

833 nsImageMap::AddArea(nsIContent* aArea)
834 {
842   Area* area;
843   switch (aArea->FindAttrValueIn(kNameSpaceID_None, nsGkAtoms::shape,
844                                  strings, eIgnoreCase)) {
862   default:
863     NS_NOTREACHED("FindAttrValueIn returned an unexpected value.");
864     break;
865   }
866   if (!area)
867     return NS_ERROR_OUT_OF_MEMORY;
868 
869   //Add focus listener to track area focus changes
870   aArea->AddEventListenerByIID(this, NS_GET_IID(nsIDOMFocusListener));

Comment 1

[timeless]

881   area->ParseCoords(coords);
882   mAreas.AppendElement(area);

Comment 2

[timeless]

Attachment: proposal

NS_NOTREACHED doesn't do anything in opt builds. the other approach would be NS_RUNTIMEABORT, I don't have an opinion.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 499382 [details] [diff] [review]
proposal

Clearing out old reviews. If this is still relevant, please re-request review for this patch.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.