Closed
Bug 620952
Opened 15 years ago
Closed 15 years ago
Fennec username/password should allow leading and trailing whitespace
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: tchung, Assigned: mbrubeck)
Details
(Keywords: polish, Whiteboard: [4.0b3])
Attachments
(1 file, 1 obsolete file)
|
1.22 KB,
patch
|
vingtetun
:
review+
|
Details | Diff | Splinter Review |
Similar to Bug 620593, but for fennec. We need to allow this in the fallback sync UI.
Tested on Fennec 4 beta 3 (build 3)
tchung: mfinkle: do we strip out trailing and whitespaces for sync credentials in fallback setup?
[07:21am] mfinkle: hmm
[07:21am] mfinkle: not in the fennec UI
[07:21am] joshua joined the chat room.
[07:21am] mfinkle: the sync backend might, 1 sec
[07:22am] tchung: i think sync key yes, but not user/pass
[07:22am] ashah joined the chat room.
[07:22am] smaug left the chat room. (Ping timeout)
[07:23am] mfinkle: right, user/pass is not trimmed
[07:23am] mfinkle: http://mxr.mozilla.org/mozilla-central/source/services/sync/modules/service.js#91
[07:24am] mfinkle: actually, sync key is not trimmed either
[07:24am] tchung: okay i'll file a bug. we have one for desktop client , bug 620593
[07:24am] mfinkle: http://mxr.mozilla.org/mozilla-central/source/services/sync/modules/service.js#133
[07:25am] GeekShadow joined the chat room.
[07:26am] mfinkle: oh, normalize passphrase does the trim currently
| Reporter | ||
Updated•15 years ago
|
Whiteboard: [4.0b3]
| Assignee | ||
Updated•15 years ago
|
Assignee: nobody → mbrubeck
tracking-fennec: --- → ?
| Assignee | ||
Comment 1•15 years ago
|
||
Attachment #499929 -
Flags: review?(mark.finkle)
| Assignee | ||
Updated•15 years ago
|
Attachment #499929 -
Flags: review?(mark.finkle) → review?(21)
Comment 2•15 years ago
|
||
Comment on attachment 499929 [details] [diff] [review]
patch
JS strings have a "trim" method now. Let's just use it:
account: this._elements.account.value.trim(),
Attachment #499929 -
Flags: review?(21) → review-
| Assignee | ||
Comment 3•15 years ago
|
||
Ah, so they do.
Attachment #499929 -
Attachment is obsolete: true
Attachment #500035 -
Flags: review?(mark.finkle)
Attachment #500035 -
Flags: review?(mark.finkle) → review+
| Assignee | ||
Comment 4•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 5•15 years ago
|
||
Can you verify this, Tony?
Comment 6•15 years ago
|
||
VERIFIED FIXED on:
Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b13pre) Gecko/20110407 Firefox/4.0b13pre Fennec /4.1a1pre
Device: HTC Desire (Android 2.2)
Status: RESOLVED → VERIFIED
Updated•12 years ago
|
tracking-fennec: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•