620968 - GetUnixXDGUserDirectory can leave rv uninitialized ifdef MOZ_PLATFORM_MAEMO

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[timeless]

474 GetUnixXDGUserDirectory(SystemDirectories aSystemDirectory,
475                         nsILocalFile** aFile)

477     char *dir = xdg_user_dir_lookup
481     nsresult rv;
482     nsCOMPtr<nsILocalFile> file;
let dir be false:
483     if (dir) {
let aSystemDirectory != Unix_XDG_Desktop
487     } else if (Unix_XDG_Desktop == aSystemDirectory) {
495     }
define MOZ_PLATFORM_MAEMO
496 #if defined(MOZ_PLATFORM_MAEMO)
let aSystemDirectory != Unix_XDG_Documents 
498     else if (Unix_XDG_Documents == aSystemDirectory) {
[skip this]
509         rv = file->AppendNative(NS_LITERAL_CSTRING(".documents"));
510     }
skip this:
511 #else
512     else {
513       // no fallback for the other XDG dirs
514       rv = NS_ERROR_FAILURE;
515     }
516 #endif

result: rv is uninitialized

Comment 1

[timeless]

Attachment: patch

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 499384 [details] [diff] [review]
patch

r+, basically NPODB.

Comment 3

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/c4c6b827e531