Closed
Bug 621000
Opened 15 years ago
Closed 14 years ago
AIX: jsnativestack.cpp fails to compile, add AIX GetNativeStackBaseImpl()
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: andrew, Assigned: andrew)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 2 obsolete files)
|
853 bytes,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
The trunk jsnativestack.cpp fails to compile under AIX because pthread.h does not define the default XP_UNIX fallback of pthread_getattr_np(). A custom AIX GetNativeStackBaseImpl() is needed.
The attached patch adds an AIX GetNativeStackBaseImpl() which uses pthread_getthrds_np().
The patch also removes a duplicate #ifdef block for SOLARIS, leaving the first one.
Attachment #499331 -
Flags: review?(mrbkap)
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #499331 -
Attachment is obsolete: true
Attachment #499379 -
Flags: review?(mrbkap)
Attachment #499331 -
Flags: review?(mrbkap)
|
|
Assignee | |
Updated•15 years ago
|
Attachment #499379 -
Flags: approval2.0?
|
|
Assignee | |
Comment 2•15 years ago
|
||
Updated the patch to add HPUX support, which was very similar.
Attachment #499379 -
Attachment is obsolete: true
Attachment #499393 -
Flags: review?(mrbkap)
Attachment #499393 -
Flags: approval2.0?
Attachment #499379 -
Flags: review?(mrbkap)
Attachment #499379 -
Flags: approval2.0?
|
||
Comment 3•14 years ago
|
||
Comment on attachment 499393 [details] [diff] [review]
Add AIX/HPUX GetNativeStackBaseImpl() using ucontext, remove duplicate Solaris one
r+ before a?, please
(we'll probably take these after we ship)
Attachment #499393 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #499393 -
Flags: review?(mrbkap) → review+
|
||
Updated•14 years ago
|
Assignee: general → andrew
|
|
||
Comment 4•14 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•