Closed
Bug 621013
Opened 15 years ago
Closed 15 years ago
add an empty firefox/l10nTests folder for mozmill-tests on 1.9.1 branch to prevent automation scripts failing
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: adriank, Assigned: adriank)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.53 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
As we don't have any localization tests on the 1.9.1 branch, the automation script for L10n tests quits with an error. To prevent that, we should have an empty firefox/l10nTests folder.
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #499346 -
Flags: review?(hskupin)
|
||
Comment 2•15 years ago
|
||
Comment on attachment 499346 [details] [diff] [review]
patch v1
Please add a dummy test which has one single test function, which should pass. Otherwise we will have troubles on the dashboard, because pass==0 will be a fail.
|
|
||
Updated•15 years ago
|
Attachment #499346 -
Flags: review?(hskupin) → review-
|
|
Assignee | |
Comment 3•15 years ago
|
||
IIRC, as the l10n tests are restart tests, we need to have at least two tests, so two dummies added. If I did remember it wrong, we could just remove one of them...
Attachment #499346 -
Attachment is obsolete: true
Attachment #500688 -
Flags: review?(hskupin)
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 500688 [details] [diff] [review]
patch v2
One test is enough. See my attachment 494220 [details] [diff] [review] for the mozilla-central case. At the same step please also give the directory the dummy name, so it will be immediately discoverable.
Attachment #500688 -
Flags: review?(hskupin) → review-
|
|
Assignee | |
Comment 5•15 years ago
|
||
(In reply to comment #4)
> Comment on attachment 500688 [details] [diff] [review]
> patch v2
>
> One test is enough. See my attachment 494220 [details] [diff] [review] for the mozilla-central case. At
> the same step please also give the directory the dummy name, so it will be
> immediately discoverable.
ok, done
Attachment #500688 -
Attachment is obsolete: true
Attachment #502901 -
Flags: review?(hskupin)
|
|
||
Comment 6•15 years ago
|
||
Comment on attachment 502901 [details] [diff] [review]
patch v3
Even for dummy patches please keep or style guide. I updated the dummy test before pushing the test.
Attachment #502901 -
Flags: review?(hskupin) → review+
|
|
||
Comment 7•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•