Closed Bug 621013 Opened 10 years ago Closed 10 years ago

add an empty firefox/l10nTests folder for mozmill-tests on 1.9.1 branch to prevent automation scripts failing

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: adriank, Assigned: adriank)

References

Details

Attachments

(1 file, 2 obsolete files)

As we don't have any localization tests on the 1.9.1 branch, the automation script for L10n tests quits with an error. To prevent that, we should have an empty firefox/l10nTests folder.
Attached patch patch v1 (obsolete) — Splinter Review
Attachment #499346 - Flags: review?(hskupin)
Comment on attachment 499346 [details] [diff] [review]
patch v1

Please add a dummy test which has one single test function, which should pass. Otherwise we will have troubles on the dashboard, because pass==0 will be a fail.
Attachment #499346 - Flags: review?(hskupin) → review-
Attached patch patch v2 (obsolete) — Splinter Review
IIRC, as the l10n tests are restart tests, we need to have at least two tests, so two dummies added. If I did remember it wrong, we could just remove one of them...
Attachment #499346 - Attachment is obsolete: true
Attachment #500688 - Flags: review?(hskupin)
Comment on attachment 500688 [details] [diff] [review]
patch v2

One test is enough. See my attachment 494220 [details] [diff] [review] for the mozilla-central case. At the same step please also give the directory the dummy name, so it will be immediately discoverable.
Attachment #500688 - Flags: review?(hskupin) → review-
Attached patch patch v3Splinter Review
(In reply to comment #4)
> Comment on attachment 500688 [details] [diff] [review]
> patch v2
> 
> One test is enough. See my attachment 494220 [details] [diff] [review] for the mozilla-central case. At
> the same step please also give the directory the dummy name, so it will be
> immediately discoverable.

ok, done
Attachment #500688 - Attachment is obsolete: true
Attachment #502901 - Flags: review?(hskupin)
Comment on attachment 502901 [details] [diff] [review]
patch v3

Even for dummy patches please keep or style guide. I updated the dummy test before pushing the test.
Attachment #502901 - Flags: review?(hskupin) → review+
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/5d8013e98242
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.