Closed Bug 621023 Opened 9 years ago Closed 9 years ago

presContext = GetPresContext() is unused ifndef DEBUG in PresShell::Paint

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b9

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug)

Details

(Keywords: coverity)

Attachments

(1 file)

6049 PresShell::Paint(nsIView*           aDisplayRoot,

6068   nsPresContext* presContext = GetPresContext();
6069   AUTO_LAYOUT_PHASE_ENTRY_POINT(presContext, Paint);

The other two call sites here inline the call into the macro saving the local variable.
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #499388 - Flags: review?(dbaron)
Attachment #499388 - Flags: approval2.0?
Comment on attachment 499388 [details] [diff] [review]
patch

r=dbaron
Attachment #499388 - Flags: review?(dbaron)
Attachment #499388 - Flags: review+
Attachment #499388 - Flags: approval2.0?
Attachment #499388 - Flags: approval2.0+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/b5f33c950290
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b9
You need to log in before you can comment on or make changes to this bug.