Closed Bug 621027 Opened 15 years ago Closed 15 years ago

AIX: jshashtable.h/jsvector.h spew due to missing private keyword

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
PowerPC
AIX
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: andrew, Assigned: andrew)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Adds missing private inheritance keyword
895 bytes, patch
mrbkap
: review+
Details | Diff | Splinter Review
The xlC compiler generates a warning for a missing private inheritance keyword (when assuming private). Simply adding this keyword silences the tons of lines of spew for every compilation: "jshashtable.h", line 57.19: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jshashtable.h", line 57.19: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jshashtable.h", line 57.19: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jsvector.h", line 195.16: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jshashtable.h", line 57.19: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jshashtable.h", line 57.19: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jshashtable.h", line 57.19: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jsvector.h", line 195.16: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jsvector.h", line 195.16: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jshashtable.h", line 57.19: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jsvector.h", line 195.16: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jsvector.h", line 195.16: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy". "jshashtable.h", line 57.19: 1540-0198 (W) The omitted keyword "private" is assumed for base class "AllocPolicy".
Attachment #499361 - Flags: review?(mrbkap)
Attachment #499361 - Flags: approval2.0?
Comment on attachment 499361 [details] [diff] [review] Adds missing private inheritance keyword r+ before a?, please (we'll probably take these after we ship)
Attachment #499361 - Flags: approval2.0?
Attachment #499361 - Flags: review?(mrbkap) → review+
Assignee: general → andrew
http://hg.mozilla.org/mozilla-central/rev/8cd268cf2411
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: