Closed
Bug 621043
Opened 14 years ago
Closed 14 years ago
AIX: avmplus.h fails in xlC due to GCC-isms only on #ifdef __powerpc__
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: andrew, Unassigned)
Details
(Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey)
Attachments
(1 file)
|
329 bytes,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
The AVMPLUS_HAS_RDTSC definition for __powerpc__ has GCC-isms that cause xlC to fail. This simply puts it under a __GNUC__ check as well to ensure xlC falls through.
Attachment #499381 -
Flags: review?(mrbkap)
|
Reporter | |
Updated•14 years ago
|
Attachment #499381 -
Flags: approval2.0?
|
||
Comment 1•14 years ago
|
||
Comment on attachment 499381 [details] [diff] [review]
Add __GNUC__ check to avmplus.h
r+ before a?, please
(we'll probably take these after we ship)
Attachment #499381 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #499381 -
Flags: review?(mrbkap) → review+
|
||
Comment 2•14 years ago
|
||
njn, we need to land this in the nanojit repo, right?
|
|
||
Comment 3•14 years ago
|
||
That's right. Here you go:
http://hg.mozilla.org/projects/nanojit-central/rev/ddf045b983f3
http://hg.mozilla.org/tracemonkey/rev/bbf2ca59e0a3
Whiteboard: fixed-in-nanojit, fixed-in-tracemonkey
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•