621152 - personas wrongly aligned at captions buttons

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Christian Ascheberg]

User-Agent:       Mozilla/5.0 (Windows NT 6.0; rv:2.0b8pre) Gecko/20101130 Firefox/4.0b8pre
Build Identifier: 

Personas are not correctly aligned at where the caption buttons are. The personas is too far on the right, though just 1px or so. The left-side border of the minimize button is hidden, while on the right of the close button the black border is just a bit to thick.

It is a regression:
works: win32 2010-11-29-03-mozilla-central 5f9204fe5cd5
broken: win32 2010-11-30-03-mozilla-central 837d7b346a64

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5f9204fe5cd5&tochange=837d7b346a64

Reproducible: Always

Steps to Reproduce:
1. choose a personas
2. see border around caption buttons

Comment 1

[Christian Ascheberg]

Attachment: screenshot

screenshot
top: 2010-11-29 vs. bottom: latest-trunk on Win Vista

Comment 2

[Christian Ascheberg]

Note: This only happens when Firefox is maximized.

Comment 3

[[not reading bugmail]]

Confirming, This is a code issue in Fx, using maximized windows with personas.

Comment 4

[Johnathan Nightingale [:johnath]]

Regression, but doesn't block.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

I'd like to renom this for blocking. Precisely carving out the caption buttons from the background image was not an easy feat because it involves getting metrics from the system and positioning a XUL element on the right position through CSS..
This, however, makes it rather fragile (this one caused by bug 606160), but if there's no unexpected trouble a patch for this should be straightforward (just changing some magic padding numbers).

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Trivial fix, and with bug 606160 this value actually makes sense, as there's 3px of distance between the close button and the edge of the screen.
Also tested in RTL.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 502613 [details] [diff] [review]
Patch

a=beltzner for Firefox 4

Comment 8

[Dietrich Ayala (:dietrich)]

This still doesn't look like a blocker. Yay for getting it fixed anyway though.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/4a5668f857fd