Closed Bug 621161 Opened 9 years ago Closed 9 years ago
add (void) to mark
If Unmarked() in js::gc::Typed Marker
igor explains that this is safe but offers to add a comment explaining in addition to a (void) annotation
Comment on attachment 499515 [details] [diff] [review] v1 > the children marking do you mean "marking the children" or "the children marking phase"? I think you probably should use one of those, r=me for one of them :)
Attachment #499515 - Flags: review?(timeless) → review+
Comment on attachment 499515 [details] [diff] [review] v1 Nominating for 2.0: this is an annotation-only patch to help with coverity analysis.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 499515 [details] [diff] [review] v1 Has landed already, so clearing redundant approval2.0?, since it's causing this fixed bug to erroneously appear under approval requests here: http://office.smedbergs.us/blocker-report/
You need to log in before you can comment on or make changes to this bug.