Closed Bug 621161 Opened 9 years ago Closed 9 years ago

add (void) to markIfUnmarked() in js::gc::TypedMarker

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: igor)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

igor explains that this is safe but offers to add a comment explaining in addition to a (void) annotation
Attached patch v1Splinter Review
Attachment #499515 - Flags: review?(timeless)
Comment on attachment 499515 [details] [diff] [review]
v1

> the children marking

do you mean "marking the children" or "the children marking phase"? I think you probably should use one of those, r=me for one of them :)
Attachment #499515 - Flags: review?(timeless) → review+
http://hg.mozilla.org/tracemonkey/rev/3e32efb4e937
Whiteboard: fixed-in-tracemonkey
Comment on attachment 499515 [details] [diff] [review]
v1

Nominating for 2.0: this is an annotation-only patch to help with coverity
analysis.
Attachment #499515 - Flags: approval2.0?
http://hg.mozilla.org/mozilla-central/rev/3e32efb4e937
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment on attachment 499515 [details] [diff] [review]
v1

Has landed already, so clearing redundant approval2.0?, since it's causing this fixed bug to erroneously appear under approval requests here:
http://office.smedbergs.us/blocker-report/
Attachment #499515 - Flags: approval2.0?
You need to log in before you can comment on or make changes to this bug.