Move JSThreadData::cachedNativeIterators into the compartment

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: igor, Assigned: igor)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(blocking2.0 betaN+)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment, 1 obsolete attachment)

v2
11.85 KB, patch
billm
: review+
Details | Diff | Splinter Review
See the bug 621032 comment 1 for reasoning.
Posted patch v1 (obsolete) — Splinter Review
Moving cachedNativeIterators into the compartment also allowed to embed the cache pointer directly into method jit generated code fixing TODO in the Compiler.cpp.
Assignee: general → igor
Status: NEW → ASSIGNED
Attachment #499734 - Flags: review?(wmccloskey)
Attachment #499734 - Flags: review?(wmccloskey) → review+
Posted patch v2Splinter Review
In v1 I forgot to move various constants related to the native iterator cache into jscompartment.h. To make sure that nothing is forgotten in v2 I wrapped the cache defs into separated class. But that requires a separated review.
Attachment #499734 - Attachment is obsolete: true
Attachment #500224 - Flags: review?(wmccloskey)
Attachment #500224 - Flags: review?(wmccloskey) → review+
https://bugzilla.mozilla.org/show_bug.cgi?id=621180
Whiteboard: fixed-in-tracemonkey
http://hg.mozilla.org/mozilla-central/rev/9cc0fd0f737a
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.