Closed
Bug 621180
Opened 14 years ago
Closed 14 years ago
Move JSThreadData::cachedNativeIterators into the compartment
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | betaN+ |
People
(Reporter: igor, Assigned: igor)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
11.85 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
See the bug 621032 comment 1 for reasoning.
|
Assignee | |
Comment 1•14 years ago
|
||
Moving cachedNativeIterators into the compartment also allowed to embed the cache pointer directly into method jit generated code fixing TODO in the Compiler.cpp.
Attachment #499734 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
In v1 I forgot to move various constants related to the native iterator cache into jscompartment.h. To make sure that nothing is forgotten in v2 I wrapped the cache defs into separated class. But that requires a separated review.
Attachment #499734 -
Attachment is obsolete: true
Attachment #500224 -
Flags: review?(wmccloskey)
Attachment #500224 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=621180
Whiteboard: fixed-in-tracemonkey
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to comment #3) > https://bugzilla.mozilla.org/show_bug.cgi?id=621180 I meant http://hg.mozilla.org/tracemonkey/rev/9cc0fd0f737a
|
||
Comment 5•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/9cc0fd0f737a
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•