621195 - ensure DocumentRoot exists on talos slaves

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

I'm seeing this on a staging slave

Dec 23 00:01:55 talos-r3-leopard-002 com.apple.launchd[1] (org.apache.httpd[595]): Exited with exit code: 1
Dec 23 00:01:55 talos-r3-leopard-002 com.apple.launchd[1] (org.apache.httpd): Throttling respawn: Will start in 10 seconds
Dec 23 00:02:05 talos-r3-leopard-002 org.apache.httpd[596]: Syntax error on line 163 of /private/etc/apache2/httpd.conf:
Dec 23 00:02:05 talos-r3-leopard-002 org.apache.httpd[596]: DocumentRoot must be a directory
Dec 23 00:02:05 talos-r3-leopard-002 com.apple.launchd[1] (org.apache.httpd[596]): Exited with exit code: 1
Dec 23 00:02:05 talos-r3-leopard-002 com.apple.launchd[1] (org.apache.httpd): Throttling respawn: Will start in 10 seconds
...

The reference platforms wiki says that directory should exist (assuming I read "mozqa" as "cltbld"):
https://wiki.mozilla.org/ReferencePlatforms/Test/Leopard#Apache_Setup

but since it doesn't, puppet should probably create it.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

This probably isn't a huge problem because:
 - the dir exists on ref images, in theory
 - the talos builds mkdir talos-data before they run

so at worst, a newly-imaged machine would fail its first talos build on Fedora because apache wasn't running.  From what I can tell, Fedora does not retry starting Apache after the initial failure.

It might fail on leopard, too, but launchd is trying to start apache every 10 seconds, so if there's more than ten seconds between making the directory and needing to access it via apache, then the tests will succeed.

Anyway, this is easy to fix in puppet.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m621195-puppet-manifests-r1.patch

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 499552 [details] [diff] [review]
m621195-puppet-manifests-r1.patch

I don't think the "staff" group exists on fedora. Looks like we use cltbld:cltbld there.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m621195-puppet-manifests-r2.patch

Nice catch.  Oddly, it did create the directory!

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 499582 [details] [diff] [review]
m621195-puppet-manifests-r2.patch

The directory should be 755, sorry I didn't catch that in the first round.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Actually, it's 775 the way the buildslave creates it.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: m621195-puppet-manifests-r3.patch

r3's the charm...

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

ace8476f11bc

Deployed to all four puppet masters.  No drama.