Last Comment Bug 621204 - Add Dict.jsm to toolkit
: Add Dict.jsm to toolkit
Status: RESOLVED FIXED
: dev-doc-complete
Product: Toolkit
Classification: Components
Component: General (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla5
Assigned To: Siddharth Agarwal [:sid0] (inactive)
:
Mentors:
Depends on:
Blocks: 621213 621564
  Show dependency treegraph
 
Reported: 2010-12-23 12:37 PST by :Gavin Sharp [email: gavin@gavinsharp.com]
Modified: 2011-04-18 13:54 PDT (History)
9 users (show)
sid.bugzilla: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch, v1 (14.81 KB, patch)
2010-12-23 12:57 PST, Siddharth Agarwal [:sid0] (inactive)
dtownsend: review+
Details | Diff | Review

Description :Gavin Sharp [email: gavin@gavinsharp.com] 2010-12-23 12:37:56 PST
See:
http://monogatari.doukut.su/2010/12/lightweight-javascript-dictionaries.html
https://hg.mozilla.org/comm-central/file/tip/mailnews/base/util/dictUtils.js

It's a general purpose JavaScript dictionary implementation. Bug 559992 would like to use it, and I see potential users in extApplication.js (SessionStorage). Thunderbird can make use of it in toolkit as well.
Comment 1 Siddharth Agarwal [:sid0] (inactive) 2010-12-23 12:57:05 PST
Created attachment 499560 [details] [diff] [review]
patch, v1

This is pretty much a straight copy-paste of the dictUtils.js in comm-central. The only thing I've changed is let to var in ES5 strict mode, per Waldo's comment.
Comment 2 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-03-16 10:59:02 PDT
Comment on attachment 499560 [details] [diff] [review]
patch, v1

Over to Dave to signoff on the addition to toolkit - this doesn't really need actual code review (though I did read through it just to familiarize myself with it).
Comment 3 Dave Townsend [:mossop] 2011-03-21 11:42:47 PDT
Comment on attachment 499560 [details] [diff] [review]
patch, v1

Fine by me as long as you document it on MDC
Comment 4 Siddharth Agarwal [:sid0] (inactive) 2011-03-23 12:55:06 PDT
https://hg.mozilla.org/mozilla-central/rev/048b078d112d

(for the record, since it was missed in the commit message, sr=Standard8 carried over from the comm-central patch.)
Comment 5 Eric Shepherd [:sheppy] 2011-04-18 13:54:16 PDT
Documentation added:

https://developer.mozilla.org/en/JavaScript_code_modules/Dict.jsm

Also mentioned on Firefox 5 for developers and the list of code modules on MDN.

Note You need to log in before you can comment on or make changes to this bug.