Add Dict.jsm to toolkit

RESOLVED FIXED in mozilla5

Status

()

Toolkit
General
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Gavin, Assigned: sid0)

Tracking

({dev-doc-complete})

unspecified
mozilla5
dev-doc-complete
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

See:
http://monogatari.doukut.su/2010/12/lightweight-javascript-dictionaries.html
https://hg.mozilla.org/comm-central/file/tip/mailnews/base/util/dictUtils.js

It's a general purpose JavaScript dictionary implementation. Bug 559992 would like to use it, and I see potential users in extApplication.js (SessionStorage). Thunderbird can make use of it in toolkit as well.
(Assignee)

Comment 1

7 years ago
Created attachment 499560 [details] [diff] [review]
patch, v1

This is pretty much a straight copy-paste of the dictUtils.js in comm-central. The only thing I've changed is let to var in ES5 strict mode, per Waldo's comment.
Assignee: nobody → sid.bugzilla
Status: NEW → ASSIGNED
Attachment #499560 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #499560 - Flags: review? → review?(gavin.sharp)
(Assignee)

Updated

7 years ago
Blocks: 621213
Blocks: 621564
Comment on attachment 499560 [details] [diff] [review]
patch, v1

Over to Dave to signoff on the addition to toolkit - this doesn't really need actual code review (though I did read through it just to familiarize myself with it).
Attachment #499560 - Flags: review?(gavin.sharp) → review?(dtownsend)
Comment on attachment 499560 [details] [diff] [review]
patch, v1

Fine by me as long as you document it on MDC
Attachment #499560 - Flags: review?(dtownsend) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/048b078d112d

(for the record, since it was missed in the commit message, sr=Standard8 carried over from the comm-central patch.)
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Documentation added:

https://developer.mozilla.org/en/JavaScript_code_modules/Dict.jsm

Also mentioned on Firefox 5 for developers and the list of code modules on MDN.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.