Closed
Bug 621204
Opened 13 years ago
Closed 13 years ago
Add Dict.jsm to toolkit
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: Gavin, Assigned: rain1)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
14.81 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
See: http://monogatari.doukut.su/2010/12/lightweight-javascript-dictionaries.html https://hg.mozilla.org/comm-central/file/tip/mailnews/base/util/dictUtils.js It's a general purpose JavaScript dictionary implementation. Bug 559992 would like to use it, and I see potential users in extApplication.js (SessionStorage). Thunderbird can make use of it in toolkit as well.
Assignee | ||
Comment 1•13 years ago
|
||
This is pretty much a straight copy-paste of the dictUtils.js in comm-central. The only thing I've changed is let to var in ES5 strict mode, per Waldo's comment.
Assignee | ||
Updated•13 years ago
|
Attachment #499560 -
Flags: review? → review?(gavin.sharp)
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 499560 [details] [diff] [review] patch, v1 Over to Dave to signoff on the addition to toolkit - this doesn't really need actual code review (though I did read through it just to familiarize myself with it).
Attachment #499560 -
Flags: review?(gavin.sharp) → review?(dtownsend)
Comment 3•13 years ago
|
||
Comment on attachment 499560 [details] [diff] [review] patch, v1 Fine by me as long as you document it on MDC
Attachment #499560 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/048b078d112d (for the record, since it was missed in the commit message, sr=Standard8 carried over from the comm-central patch.)
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Flags: in-testsuite+
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.2
Comment 5•13 years ago
|
||
Documentation added: https://developer.mozilla.org/en/JavaScript_code_modules/Dict.jsm Also mentioned on Firefox 5 for developers and the list of code modules on MDN.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•