621262 - AndroidManifest.xml.in implies that GPS location support is mandatory

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Atoll]

The manifest [3] specifies <uses-permission .. ACCESS_FINE_LOCATION> [1] without any <uses-feature> tags for location and location.gps [2].  This will result in Firefox being hidden in the Market from users with phones that don't offer both the location and location.gps features.  I believe the following tags will resolve this, as long as Firefox Mobile is capable of working without gps support.


<uses-feature android:name="android.hardware.location" android:required="false" />
<uses-feature android:name="android.hardware.location.gps" android:required="false" />


[1] http://developer.android.com/guide/appendix/market-filters.html
[2] http://developer.android.com/guide/topics/manifest/uses-feature-element.html#permissions-features
[3] http://hg.mozilla.org/mozilla-central/file/6d22eaba6e95/embedding/android/AndroidManifest.xml.in

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Also adds a uses-feature element for touchscreen, while we're at it.

Comment 2

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mozilla-central/rev/f47110e73a21

Comment 3

[Anna (Waverley)]

Can you provide some steps to reproduce for this bug, please?

Comment 4

[Matt Brubeck (:mbrubeck)]

This should be verified by installing Fennec on a device without GPS,  Richard, do you have such a device?

Comment 5

[:Atoll]

Nope, sorry, only came across this by accident while reading through the manifest for unrelated reasons.

Comment 6

[Cristian Nicolae (:xti)]

(In reply to Matt Brubeck (:mbrubeck) from comment #4)
> This should be verified by installing Fennec on a device without GPS, 
> Richard, do you have such a device?

If I disable the GPS on my device, will it be the same as a device without GPS?