Closed Bug 621262 Opened 9 years ago Closed 9 years ago

AndroidManifest.xml.in implies that GPS location support is mandatory

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set

Tracking

(fennec2.0b4+)

RESOLVED FIXED
fennec2.0b4
Tracking Status
fennec 2.0b4+ ---

People

(Reporter: Atoll, Assigned: mbrubeck)

References

Details

Attachments

(1 file)

The manifest [3] specifies <uses-permission .. ACCESS_FINE_LOCATION> [1] without any <uses-feature> tags for location and location.gps [2].  This will result in Firefox being hidden in the Market from users with phones that don't offer both the location and location.gps features.  I believe the following tags will resolve this, as long as Firefox Mobile is capable of working without gps support.


<uses-feature android:name="android.hardware.location" android:required="false" />
<uses-feature android:name="android.hardware.location.gps" android:required="false" />


[1] http://developer.android.com/guide/appendix/market-filters.html
[2] http://developer.android.com/guide/topics/manifest/uses-feature-element.html#permissions-features
[3] http://hg.mozilla.org/mozilla-central/file/6d22eaba6e95/embedding/android/AndroidManifest.xml.in
tracking-fennec: --- → ?
OS: Mac OS X → Android
Hardware: x86 → All
Attached patch patchSplinter Review
Also adds a uses-feature element for touchscreen, while we're at it.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #499943 - Flags: review?(blassey.bugs)
Attachment #499943 - Flags: review?(blassey.bugs) → review+
Blocks: 621645
tracking-fennec: ? → 2.0b4+
http://hg.mozilla.org/mozilla-central/rev/f47110e73a21
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → fennec2.0b4
Can you provide some steps to reproduce for this bug, please?
This should be verified by installing Fennec on a device without GPS,  Richard, do you have such a device?
Nope, sorry, only came across this by accident while reading through the manifest for unrelated reasons.
(In reply to Matt Brubeck (:mbrubeck) from comment #4)
> This should be verified by installing Fennec on a device without GPS, 
> Richard, do you have such a device?

If I disable the GPS on my device, will it be the same as a device without GPS?
You need to log in before you can comment on or make changes to this bug.