621271 - nsIPresShell.h causes very many warnings on Windows whose system locale is non-Western

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

> warning C4819: The file contains a character that cannot be represented in the current code page (932). Save the file in Unicode format to prevent data loss

The cause is that there is a non-ASCII character in the license block.

> 25  *   Mihai Șucan <[e-mail]>

Mihai, cannot you use only ASCII character for your name? nsIPresShell is included by very very many files. Therefore, the waring is printed very many times when I rebuild my tree.

Note that on Windows, console messages are displayed synchronously, therefore, painting the message causes slower.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: name change

Ouch. Sorry about that. Attaching a patch which changes my name to use only ASCII chars.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Can't we just tell the compiler that our files are UTF-8?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to comment #2)
> Can't we just tell the compiler that our files are UTF-8?

VC++ 2005 requires BOM if source code is detected as UTF-8.

Comment 4

[Simon Montagu :smontagu]

... and in case anyone is considering adding BOMs to source files, note that they confuse mxr

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

According to comment 2 and comment 3, we have no way to use UTF-8. I hope the patch will be landed soon.

dbaron, do you still have objection?

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

No, go ahead.

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://hg.mozilla.org/mozilla-central/rev/8d9465a318f5