621273 - Internal URLs show up as results after RSS feed preview

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Christian Ascheberg]

User-Agent:       Mozilla/5.0 (Windows NT 6.0; rv:2.0b9pre) Gecko/20101223 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Windows NT 6.0; rv:2.0b9pre) Gecko/20101223 Firefox/4.0b9pre

See STR below.
This is a regression:
works:
win32 2010-12-15-03-mozilla-central f11f7ed625ba
broken:
win32 2010-12-16-03-mozilla-central a5413c3c1013

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f11f7ed625ba&tochange=a5413c3c1013

Reproducible: Always

Steps to Reproduce:
(you might start with a new profile)
1. type "add" into location bar (no results with clean profile)
2. open RSS feed in preview, for example given URL
3. type "add" into location bar again
Actual Results:  
These two URL show up as results:
http://add.my.yahoo.com/rss?url=%s
http://www.google.com/ig/add?feedurl=%s

Expected Results:  
Those URL should not be shown, because they were not visited.

Comment 1

[Alice0775 White]

Confirmed.

Works:
http://hg.mozilla.org/mozilla-central/rev/e435c9812855
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20101215 Firefox/4.0b9pre ID:20101215174043
Fails:
http://hg.mozilla.org/mozilla-central/rev/cd62a8afc52e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20101215 Firefox/4.0b9pre ID:20101215204205
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e435c9812855&tochange=cd62a8afc52e

Comment 2

[Alice0775 White]

Linux too
http://hg.mozilla.org/mozilla-central/rev/ef42c524718f
Mozilla/5.0 (X11; Linux i686; rv:2.0b9pre) Gecko/20101223 Firefox/4.0b9pre ID:20101223030401

Comment 3

[Christian Ascheberg]

(In reply to comment #1)

How do you find those close regression ranges? Are there still hourly builds or so for that date?

Comment 4

[Alice0775 White]

(In reply to comment #3)
> (In reply to comment #1)
> 
> How do you find those close regression ranges? Are there still hourly builds or
> so for that date?

I cached hourly build on local HDD.
And you can find archived hourly on http://hourly-archive.localgho.st/hourly-archive2/mozilla-central-win32/

Comment 5

[(mostly gone) XtC4UaLL [:xtc4uall]]

Guess we need a Range on Places Branch, no?

Comment 6

[Alice0775 White]

In local build
Build from af7e6f7cbf16 : fails
Build from 2a7a3641d67d : fails
Build from 6617dcb0d48a : fails
Build from d65c65ef13a4 : works
Build from 20311c05703e : works
Build from b198eca4d183 : works
Build from 4626f19fa27e : works

So, this is regressen by Bug 599973 - Don't use steps for async favicons

Comment 7

[Alice0775 White]

And also
Build from 999385f355a3 : fails

Comment 8

[Shawn Wilsher :sdwilsh]

Thanks for digging into this and getting a regression range!

Comment 9

[Marco Bonardo [:mak]]

see https://bugzilla.mozilla.org/show_bug.cgi?id=621274#c7

Comment 10

[Marco Bonardo [:mak]]

those urls are there because we fetch icons for the default web handlers for RSS feeds (the feed preview page uses those icons for google and yahoo).
I will fix this bug along with bug 621274 since they are related.

Comment 11

[Tomas]

Bug 621274 is foxed now.

Comment 12

[Marco Bonardo [:mak]]

fixed by the check-in of bug 621274
http://hg.mozilla.org/mozilla-central/rev/1c1216dcafed

Comment 13

[u279076]

I can still reproduce this using:
Mozilla/5.0 (X11; Linux i686; rv:2.0b10pre) Gecko/20110121 Firefox/4.0b10pre
 - and - 
Mozilla/5.0 (X11; Linux i686; rv:2.0b10) Gecko/20100101 Firefox/4.0b10 (build1)

Comment 14

[Marco Bonardo [:mak]]

Thanks for looking again at this, I was pretty sire to have tested this case but looks like it slipped out.
Now we correctly set hidden=1 but we let frecency to the default value (-1), autocomplete is now basing its behavior on frecency rather than hidden, so we consider these entries "to-be-recalculated". Next frecency recalculation will fix this but in the meanwhile the uris are showing up.
I'll increase the strictness of the fix in bug 621274 to also set frecency to 0.

Comment 15

[Marco Bonardo [:mak]]

Attachment: patch v1.0 (checked-in)

Shawn, I'd directly go to central with this, should not bitrot anything we could put on the branch.

Comment 16

[Shawn Wilsher :sdwilsh]

Comment on attachment 506412 [details] [diff] [review]
patch v1.0 (checked-in)

r=sdwilsh

Comment 17

[Marco Bonardo [:mak]]

Comment on attachment 506412 [details] [diff] [review]
patch v1.0 (checked-in)

http://hg.mozilla.org/mozilla-central/rev/2c27b1eb2085

Comment 18

[Steve Scott (pxbugz)]

Verified fixed on Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b12pre) Gecko/20110204 Firefox/4.0b12pre