Closed Bug 621347 Opened 13 years ago Closed 11 years ago

[SeaMonkey, WINNT 5.2, Debug] mochitests-1: intermittent "test_ws_basic_tests.html | Test timed out"

Categories

(Core :: Networking: WebSockets, defect)

Product:
Core
Component:
Networking: WebSockets
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b9

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [SeaMonkey "orange" issue moved to bug 736325])

Attachments

(3 files, 2 obsolete files)

(Av1) s/ok/is/ typo fix from bug 562681 [Checked in: Comment 9]
993 bytes, patch
smaug
: review+
Details | Diff | Splinter Review
(Bv1) Add/Re-enable '.wasClean' checks from (bug 573227 ->) bug 572975 [Checked in: Comment 13]
3.52 KB, patch
smaug
: review+
Details | Diff | Splinter Review
(Dv1) testWebSocket4(): stop generating a 508 KiB log line from bug 562681 [Checked in: See comment 10]
2.07 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
Bug 574070 comment 16:
{{
Serge Gautherie (:sgautherie)      2010-11-18 21:28:27 PST

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1290134463.1290139655.3881.gz
WINNT 5.2 comm-central-trunk debug test mochitests-1/5 on 2010/11/18 18:41:03
{
...
31011 INFO TEST-PASS | /tests/content/base/test/test_ws_basic_tests.html |
Wrong message - "test message100" should equal "test message100"
31012 ERROR TEST-UNEXPECTED-FAIL |
/tests/content/base/test/test_ws_basic_tests.html | Test timed out.
31013 INFO TEST-END | /tests/content/base/test/test_ws_basic_tests.html |
finished in 354923ms
}

354.923 s +=- 360 s : this test can simply be to slow as is.
}}

***

Test has completed the expected 100 iterations of testWebSocket3 onmessage(),
but testWebSocket3 onclose() doesn't run :-(
Summary: [SeaMonkey, WINNT 5.2, Debug] → [SeaMonkey, WINNT 5.2, Debug] mochitests-1: intermittent "test_ws_basic_tests.html | Test timed out"
Blocks: 562681, 572975

        Attachment #499715 -
        Flags: review?(Olli.Pettay)

    
  
Blocks: 621390

    
    

    
  


  
I wanted to check a SeaMonkey green run log, I found bug 621390 instead :-/

Let's fix this, then we'll see...

        Attachment #499724 -
        Flags: review?(Olli.Pettay)

    
  

        Attachment #499724 -
        Attachment description: (Dv1) testWebSocket4(): stop generating a 508 KiB log line → (Dv1) testWebSocket4(): stop generating a 508 KiB log line from bug 562681

        Attachment #499709 -
        Flags: review?(Olli.Pettay) → review+

    
    

    
  
Um, somewhat unrelated patches in one bug :/

        Attachment #499724 -
        Flags: review?(Olli.Pettay) → review+

    
    

    
  
Comment on attachment 499710 [details] [diff] [review]
(Bv1) Add/Re-enable '.wasClean' checks from (bug 573227 ->) bug 572975
[Checked in: Comment 13]

Why you change the comments in the ok() checks?

    
    

    
  
Comment on attachment 499715 [details] [diff] [review]
(Cv1) Document/Improve code, somewhat

Kind of hard to see what is changed and why.
Will review a bit later.

    
    

    
  
(In reply to comment #6)
> Why you change the comments in the ok() checks?

"Should have" should be implied by ok(), I think.
(Yet I'll use whatever comment you want.)

    
    

    
  
Comment on attachment 499709 [details] [diff] [review]
(Av1) s/ok/is/ typo fix from bug 562681
[Checked in: Comment 9]

http://hg.mozilla.org/mozilla-central/rev/d14e3a26d5a0

        Attachment #499709 -
        Attachment description: (Av1) s/ok/is/ typo fix from bug 562681 → (Av1) s/ok/is/ typo fix from bug 562681
[Checked in: Comment 9]

    
    

    
  
Comment on attachment 499724 [details] [diff] [review]
(Dv1) testWebSocket4(): stop generating a 508 KiB log line from bug 562681
[Checked in: See comment 10]

http://hg.mozilla.org/mozilla-central/rev/ec3e4786877d
Dv1, but applied before patches B and C.

        Attachment #499724 -
        Attachment description: (Dv1) testWebSocket4(): stop generating a 508 KiB log line from bug 562681 → (Dv1) testWebSocket4(): stop generating a 508 KiB log line from bug 562681
[Checked in: See comment 10]

    
    

    
  


  
Cv1, unbitrotted.

        Attachment #499715 -
        Attachment is obsolete: true

        Attachment #500318 -
        Flags: review?(Olli.Pettay)

        Attachment #499715 -
        Flags: review?(Olli.Pettay)

    
    

    
  
Comment on attachment 499710 [details] [diff] [review]
(Bv1) Add/Re-enable '.wasClean' checks from (bug 573227 ->) bug 572975
[Checked in: Comment 13]

If this causes new random orange, please back out and
file bugs for those problems.

        Attachment #499710 -
        Flags: review?(Olli.Pettay) → review+

    
    

    
  
Comment on attachment 499710 [details] [diff] [review]
(Bv1) Add/Re-enable '.wasClean' checks from (bug 573227 ->) bug 572975
[Checked in: Comment 13]

http://hg.mozilla.org/mozilla-central/rev/13adcde8f131

        Attachment #499710 -
        Attachment description: (Bv1) Add/Re-enable '.wasClean' checks from (bug 573227 ->) bug 572975 → (Bv1) Add/Re-enable '.wasClean' checks from (bug 573227 ->) bug 572975
[Checked in: Comment 13]

    
    

    
  
Comment on attachment 500318 [details] [diff] [review]
(Cv1a) Document/Improve code, somewhat
[Moved to bug 744663]

Is this still needed?

        Attachment #500318 -
        Flags: review?(Olli.Pettay)

    
  
Blocks: 736325

    
  
No longer blocks: SmTestFail

    
  
No longer blocks: 438871

    
  
Assignee: nobody → sgautherie.bz
Status: NEW → RESOLVED
Closed: 11 years ago
Component: DOM → Networking: WebSockets
Flags: in-testsuite+
OS: Windows Server 2003 → All
QA Contact: general → networking.websockets
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [orange] → [SeaMonkey issue moved to bug 736325] [orange]
Target Milestone: --- → mozilla2.0b9

    
  
Blocks: 744663

    
    

    
  
Comment on attachment 500318 [details] [diff] [review]
(Cv1a) Document/Improve code, somewhat
[Moved to bug 744663]

(In reply to Olli Pettay [:smaug] from comment #14)
> Is this still needed?

Yes: "Bug 744663 Submitted".

        Attachment #500318 -
        Attachment description: (Cv1a) Document/Improve code, somewhat → (Cv1a) Document/Improve code, somewhat
[Moved to bug 744663]

        Attachment #500318 -
        Attachment is obsolete: true

    
  
Blocks: 438871

    
  
No longer blocks: 438871
Whiteboard: [SeaMonkey issue moved to bug 736325] [orange] → [SeaMonkey "orange" issue moved to bug 736325]

          You need to log in
          before you can comment on or make changes to this bug.