Bug 574070 comment 16: {{ Serge Gautherie (:sgautherie) 2010-11-18 21:28:27 PST http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1290134463.1290139655.3881.gz WINNT 5.2 comm-central-trunk debug test mochitests-1/5 on 2010/11/18 18:41:03 { ... 31011 INFO TEST-PASS | /tests/content/base/test/test_ws_basic_tests.html | Wrong message - "test message100" should equal "test message100" 31012 ERROR TEST-UNEXPECTED-FAIL | /tests/content/base/test/test_ws_basic_tests.html | Test timed out. 31013 INFO TEST-END | /tests/content/base/test/test_ws_basic_tests.html | finished in 354923ms } 354.923 s +=- 360 s : this test can simply be to slow as is. }} *** Test has completed the expected 100 iterations of testWebSocket3 onmessage(), but testWebSocket3 onclose() doesn't run :-(
Created attachment 499709 [details] [diff] [review] (Av1) s/ok/is/ typo fix from bug 562681 [Checked in: Comment 9]
Created attachment 499710 [details] [diff] [review] (Bv1) Add/Re-enable '.wasClean' checks from (bug 573227 ->) bug 572975 [Checked in: Comment 13]
Created attachment 499715 [details] [diff] [review] (Cv1) Document/Improve code, somewhat
Created attachment 499724 [details] [diff] [review] (Dv1) testWebSocket4(): stop generating a 508 KiB log line from bug 562681 [Checked in: See comment 10] I wanted to check a SeaMonkey green run log, I found bug 621390 instead :-/ Let's fix this, then we'll see...
Um, somewhat unrelated patches in one bug :/
Comment on attachment 499710 [details] [diff] [review] (Bv1) Add/Re-enable '.wasClean' checks from (bug 573227 ->) bug 572975 [Checked in: Comment 13] Why you change the comments in the ok() checks?
Comment on attachment 499715 [details] [diff] [review] (Cv1) Document/Improve code, somewhat Kind of hard to see what is changed and why. Will review a bit later.
(In reply to comment #6) > Why you change the comments in the ok() checks? "Should have" should be implied by ok(), I think. (Yet I'll use whatever comment you want.)
Comment on attachment 499709 [details] [diff] [review] (Av1) s/ok/is/ typo fix from bug 562681 [Checked in: Comment 9] http://hg.mozilla.org/mozilla-central/rev/d14e3a26d5a0
Comment on attachment 499724 [details] [diff] [review] (Dv1) testWebSocket4(): stop generating a 508 KiB log line from bug 562681 [Checked in: See comment 10] http://hg.mozilla.org/mozilla-central/rev/ec3e4786877d Dv1, but applied before patches B and C.
Created attachment 500318 [details] [diff] [review] (Cv1a) Document/Improve code, somewhat [Moved to bug 744663] Cv1, unbitrotted.
Comment on attachment 499710 [details] [diff] [review] (Bv1) Add/Re-enable '.wasClean' checks from (bug 573227 ->) bug 572975 [Checked in: Comment 13] If this causes new random orange, please back out and file bugs for those problems.
Comment on attachment 499710 [details] [diff] [review] (Bv1) Add/Re-enable '.wasClean' checks from (bug 573227 ->) bug 572975 [Checked in: Comment 13] http://hg.mozilla.org/mozilla-central/rev/13adcde8f131
Comment on attachment 500318 [details] [diff] [review] (Cv1a) Document/Improve code, somewhat [Moved to bug 744663] Is this still needed?
Comment on attachment 500318 [details] [diff] [review] (Cv1a) Document/Improve code, somewhat [Moved to bug 744663] (In reply to Olli Pettay [:smaug] from comment #14) > Is this still needed? Yes: "Bug 744663 Submitted".
or
