621365 - localstorage session-only determination in parent process is broken via IPC

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Josh Matthews [:jdm]]

The parent's DOMStorageImpl mSessionOnly var is only determined at creation, which is very incorrect.  I believe we need to forward the child's mSessionOnly with each operation we perform.

Comment 1

[Josh Matthews [:jdm]]

This should block, as it breaks the expected storage lifetime of localstorage instances used with session cookies,

Comment 2

[Josh Matthews [:jdm]]

Attachment: Forward child session-only status to parent.

Comment 3

[Honza Bambas (:mayhemer)]

I had an idea to move check for session-only to the chrome process completely (send just the subject URI to inspect it by the storage implementation later) but I didn't measure any performance benefit.

I'll review your patch soon.

Comment 4

[Honza Bambas (:mayhemer)]

Comment on attachment 499704 [details] [diff] [review]
Forward child session-only status to parent.

> sync protocol PStorage

>   sync GetKeys(bool callerSecure)
>       returns (nsString[] keys);

I am not sure of this method if it also needs to pass sessionOnly arg.  If so, then it is probably a different bug, and probably present before remoting dom storage.

>+  void ForceSessionOnly(bool aSessionOnly);

Maybe rather just SetSessionOnly ?

r=honzab

Comment 5

[Josh Matthews [:jdm]]

http://hg.mozilla.org/mozilla-central/rev/ab1fb1ff3662