621481 - App Tab Icons shift upwards when closing a normal tab

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Will Roberts [:bws42]]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9pre) Gecko/20101226 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b9pre) Gecko/20101226 Firefox/4.0b9pre

If you have App Tabs and close a normal tab the icon will shift upwards a pixel.

Reproducible: Always

Comment 1

[Will Roberts [:bws42]]

Regression range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=52b229f6a051&tochange=3e4f01f2a119

So this looks like it came from bug 617522

Comment 2

[rob64rock]

This bug 621481 description should say: "App Tab Icons shifts downwards a pixel when closing the last normal tab"

If I have a App tab(pinned tab) and Regular tab, then I close the Regular tab the App Tab favicon shifts down a pixel and so does the Navigation bar. Or you could also perceive it has the Navigation bar and App tab favicon shifts up a pixel when you open a Regular tab, when only having App tabs(pinned tabs) on Tabbar.

This bug 617522 - "Tab strip moves a pixel when you have app tabs open and close the last normal tab" mentions the similar problem, but it says it has been fixed.

I figured that bug would of fix what we are seeing, but it still occurs even after Bug 617522 had been fixed and has landed in Nightly Trunk builds.

Comment 3

[Will Roberts [:bws42]]

(In reply to comment #2)
> This bug 621481 description should say: "App Tab Icons shifts downwards a pixel
> when closing the last normal tab"

No, the icons moving downward when the last normal tab is closed places them back where they should be. If I have only app tabs the icons appear centered. If I then open a normal tab the icons remain centered. Finally if I open another normal tab and close it, so I now have my app tabs and a single normal tab, the icons shift upwards by 1 pixel.

Closing the last normal tab then causes the app tab icons to return to their normal location.

Comment 4

[Will Roberts [:bws42]]

Attachment: movement of app tab icons

1. Just app tabs, icons appear centered
2. App tabs and one normal tab, icons appear centered
3. App tabs and one normal tab after opening and closing an additional tab, icons offset

Comment 5

[Will Roberts [:bws42]]

CC'ing Dao since he reviewed the patch that caused this.

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Fryn and I debugged this yesterday. The cause of this problem is that the min-height semantic changes between display:-moz-box and block (in one case it includes the borders, and in the other it doesn't).

Regular tabs have a min-height rule of 25px, which accounts for their 18px + 7px on borders. When changing to display:block and position:fixed, the rule is changed to 18px.
However, on the pinnedonly=true case (which doesn't change the display property), the min-height of 18px is still set (overriding the 25px), meaning that the actual min-height being forced is only 18-7 = 11px (although other elements such as the favicon keep the tab at 17px, thus only a 1px difference is seem).

This is only currently visible on the linux theme when most tabbar buttons have been removed from it (some of the buttons also help to keep the height at 18px)

Comment 7

[rob64rock]

(In reply to comment #6)
> Fryn and I debugged this yesterday. The cause of this problem is that the
> min-height semantic changes between display:-moz-box and block (in one case it
> includes the borders, and in the other it doesn't).
> 
> Regular tabs have a min-height rule of 25px, which accounts for their 18px +
> 7px on borders. When changing to display:block and position:fixed, the rule is
> changed to 18px.
> However, on the pinnedonly=true case (which doesn't change the display
> property), the min-height of 18px is still set (overriding the 25px), meaning
> that the actual min-height being forced is only 18-7 = 11px (although other
> elements such as the favicon keep the tab at 17px, thus only a 1px difference
> is seem).
> 
> This is only currently visible on the linux theme when most tabbar buttons have
> been removed from it (some of the buttons also help to keep the height at 18px)

My post in Comment 2, I neglected to say I was using WinXp not Linux, but the same STR apply for me has for Linux users.

Comment 8

[Dão Gottwald [:dao]]

Attachment: patch

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 510568 [details] [diff] [review]
patch

a=beltzner, little polish fix, with a scolding to fryn and felipe for not working on more important little polish fixes

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/1830671ed3e0

Comment 11

[George Carstoiu]

Mozilla/5.0 (X11; Linux i686; rv:2.0b12pre) Gecko/20110217 Firefox/4.0b12pre

Verified issue and it's no longer present.