Closed Bug 621637 Opened 11 years ago Closed 11 years ago

Compatibility: google.com search input issue

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(fennec2.0+)

VERIFIED FIXED
Tracking Status
fennec 2.0+ ---

People

(Reporter: tarend, Assigned: vingtetun)

References

Details

Attachments

(4 files)

Attached image Screenshot 1
found in 20101227 nightly on N1 and Droid II
(1) go to google.com
(2) enter search term (e.g. "San Francisco")

Result: grey block (from form helper with no arrows) shows above VKB (see screenshot 1) and even moves down to bottom (screenshot 2) when VKB disappears
Expected: no form helper shown

(3) click on map in search result

Result: (screenshot 3) VKB shows for a few seconds and then disappears
Expected: VKB doesn't show

See also 621634 (issues with Google Maps)
Attached image Screenshot 2
Attached image Screenshot 3
tracking-fennec: --- → ?
Thomas, do you have the error console enabled (it is situated next to the Beta panel), if yes could you try to see if you have any error messages in it?

Otherwise you could enabled it by going to the Beta panel and turn the "Enable the Error Console" pref to true.

Also for step (2) are you using the keyboard or you finger to validate your input?
Vivien, I only saw CSS warnings, no errors. 
The latest nightly 20101229 shows a similar behavior: the gray form helper bar remains on the bottom of the search result screen, even after entering the search term and hitting return. Today I see the up/down arrows, but there is no way to make the bar go away.

Errors in the console:
Exception: Empty rectangles do not have centers

Note: this problem seems to occur only on the full Google page. I don't see it when setting Phony to "Android".
Let me know if you need any more info.
(In reply to comment #4)
> Vivien, I only saw CSS warnings, no errors. 
> The latest nightly 20101229 shows a similar behavior: the gray form helper bar
> remains on the bottom of the search result screen, even after entering the
> search term and hitting return. Today I see the up/down arrows, but there is no
> way to make the bar go away.
> 
> Errors in the console:
> Exception: Empty rectangles do not have centers
> 
> Note: this problem seems to occur only on the full Google page. I don't see it
> when setting Phony to "Android".
> Let me know if you need any more info.

If you see the arrows, I know what is the problem so this sounds better to me. It looks like google.com url format has changed and does not redirect you to an other page during a search but instead keep the same url and update only the fragment identifier of the url.

Since this fragment is normally use to prevent dismissing the FormHelperUI/ZoomLevel we are busted on the normal google page.

I'm still unsured of the right fix for it because if we reset the zoom level or dismiss the form helper for simple fragment change it makes google translate unusable.

I need to think about it more, my only idea for now if to use the google.com based page url pattern to add an exception since this is the only page I've seen like that but I'm pretty sure I'm wrong :s
Attached patch PatchSplinter Review
This fix the case of the Form Assistant, which means the bottom navigator disappears when needed for this case.

The scroll position are handle by the google page itself and will be fixed by bug 479862

My problem now if for the resetting the zoom cases, I've not yet found a good pattern for it, so I would like to land the first patch and keep this bug open until we decide what to do.
Attachment #500490 - Flags: review?(mark.finkle)
tracking-fennec: ? → 2.0+
Viven - do you want a review?
Assignee: nobody → 21
(In reply to comment #8)
> Viven - do you want a review?

Sorry I should have commented here. a fix for the Form Helper has been landed into an other bug and my patch was mostly about it so I don't need a review.

As said previously the scroll case would be handle by the resolution of the old scrollX/scrollY positions are not synced.

For the zoom part I still have no good ways to reset it for now.
So, since bug 479862 has landed, this bug should be as fixed as it's goning to get
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Note: from Comment 9: Zooming will show this issue
1) in landscape mode with keyboard out, go to www.google.com
2) enter search term "San Francisco" without hitting return
3) zoom in
4) close hardware keyboard and go to portrait view
Verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110517 Firefox/6.0a1 Fennec/6.0a1 
Device: LG Optimus 2X (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.