621802 - [regression] UI blocks for >3 seconds in PlacesUtils.getMostRecentBookmarkForURI

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Using recent Fennec nightlies on Android (for at least the past week), the UI freezes and becomes completely unresponsive for several hundred milliseconds during each page load.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Each pageload does trigger some Places code, both internally and in our front end. For example, we check to see if the page is bookmarked and if so, we toggle the "star".

Comment 2

[Matt Brubeck (:mbrubeck)]

I verified that the updateStar function frequently takes 3-5 seconds (!) to return on my Galaxy Tab with a large profile, and this seems to correspond with the page loads where the UI is unresponsive.

Comment 3

[Matt Brubeck (:mbrubeck)]

It looks like Minefield recently fixed this in bug 613477; we can the same PlacesUtils code to fix it in Fennec.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Using PlaceUtils.asyncGetBookmarkIds  ?

Comment 5

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Use async bookmark lookup during page load.  This fixes the problem for me on desktop and device.  Bookmark tests still pass with this patch (on desktop).

Comment 6

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/mobile-browser/rev/5efd73e3566d

Comment 7

[Shawn Wilsher :sdwilsh]

I, for one, love our new async overlords.

Comment 8

[Shawn Wilsher :sdwilsh]

*and* this appears to have gotten us a Ts win (at last on Tracemonkey), which is expected since you aren't doing synchronous I/O on the GUI thread during startup anymore!

Fennec may even want to whitelist the default home page so that no lookup is done (we whitelisted about:blank in PlacesUtils code).

Comment 9

[Aakash Desai [:aakashd]]

The browser certainly doesn't hang for >3 seconds, but there's a very noticeable hang for ~1 sec once the title and favicon are updated for the page and content is loading onto the window. 

The pages I tried and found this issue on are:

www.espn.com
www.facebook.com
bugzilla.mozilla.org

The pages I tried and did NOT find this issue on are:

addons.mozilla.org
about:firefox

Also, there's a noticeable hang when going to the controls panel as well which I think it related to this. Should I file another bug here?

Comment 10

[Aakash Desai [:aakashd]]

never mind, filed follow-up bug https://bugzilla.mozilla.org/show_bug.cgi?id=622112