621848 - memory leak in nsNSSComponent::IdentityInfoInit

Status: VERIFIED FIXED

(Core :: Security: PSM, defect)

Description

[Boying Lu]

Using libumem.so provided by OpenSolaris and run following test case, I find a memory leak in nsNSSComponent::IdentityInfoInit

Test case:
1. Run Thunderbird trunk buid
2. Click 'Cancel' button in the password dialog
3. Quit from Thunderbird

The libumem.so shows a memory leak and the following is the trace stack

> 0c4e1908::bufctl_audit
            ADDR          BUFADDR        TIMESTAMP           THREAD
                            CACHE          LASTLOG         CONTENTS
         c4e1908          c4e26a0     b578ebb7cf89               14
                          807c510                0                0
                 libumem.so.1`umem_cache_alloc_debug+0x158
                 libumem.so.1`umem_cache_alloc+0x157
                 libumem.so.1`umem_alloc+0xd0
                 libumem.so.1`malloc+0x2d
                 libnspr4.so`PR_Malloc+0x63
                 libnssutil3.so`PORT_Alloc_Util+0x46
                 libnssutil3.so`SECITEM_AllocItem_Util+0xfb
                 libnssutil3.so`NSSBase64_DecodeBuffer_Util+0x99
                 libnssutil3.so`ATOB_ConvertAsciiToItem_Util+0x7a
                 libnss3.so`ATOB_ConvertAsciiToItem+0x2e
                 libxul.so`PRStatus nsNSSComponent::IdentityInfoInit+0x84
                 libnspr4.so`PR_CallOnce+0x5e
                 
                 libxul.so`unsigned nsNSSComponent::EnsureIdentityInfoLoaded+0x3
                 7
                 libxul.so`unsigned nsNSSCertificate::hasValidEVOidTag+0x102
                 libxul.so`unsigned nsNSSCertificate::getValidEVOidTag+0x75

Comment 1

[Boying Lu]

Attachment: patch

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 500173 [details] [diff] [review]
patch

The same should be made in function loadTestEVInfos (the same file).

r=honzab

Comment 3

[Boying Lu]

Attachment: add same codes in loadTestEVInfos

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 501585 [details] [diff] [review]
add same codes in loadTestEVInfos

Can we get approval2.0 for this?  This is a low-risk mlk fix.

Comment 5

[(no longer active)]

This needs approval2.0+ before it can be checkin-needed.

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/70ca6a1b9d29