621886 - prerelease.html is a mess

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

prerelease.html has numerous validation errors and inline styles. Also, the lack of indentation in the script makes it needlessly hard to read and it is inconsistent in checking document.getElementById support.

(It is not clear to me whether

  <div>
  <input name="useragent" id="useragent" value="Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032504 Minefield/3.0b5pre" type="hidden">
  <input id="product" name="product" value="Minefield" type="hidden">
  <input name="action" value="submit" type="hidden">
  </div>

does anything, maybe it could be removed as well.)

Patch applies over bug 621755.

Comment 1

[David Boswell]

Yes, the page is a mess.  I'm certainly fine with fixing errors, but I think it will be better to rethink this page entirely.

Comment 2

[Reed Loden [:reed]]

Comment on attachment 500188 [details] [diff] [review]
Patch v1

Agree with David. This page needs a complete rewrite, as we're no longer using Hendrix or Reporter.

>+</style>
>+'

Missing semicolon.

I stopped reading after that, as I saw hendrix code, which needs to be removed.

Comment 3

[David Boswell]

I recently completely revamped this page.  Take a look and let me know if that fixes this bug.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

-    <li><a href="http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=48+hours+ago&enddate=now">Last 48 hours of check-ins</a></li>
+    <li><a href="http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=48+hours+ago&amp;enddate=now">Last 48 hours of check-ins</a></li>

still needs to be applied. Looks better otherwise.

Comment 5

[David Boswell]

OK, fixed in r88038.