Closed Bug 621913 Opened 9 years ago Closed 9 years ago

Re-enable the 'click' test for browser_forms.js

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
No description provided.
Attachment #500205 - Flags: review?(mbrubeck)
Comment on attachment 500205 [details] [diff] [review]
Patch

> AsyncTests.add("Test:Click", function(aMessage, aJson) {
>+  // since sendMouseEvent from EventUtils try to request privilege we don't
>+  // need here, and this fire a dialog box we don't want just disabled them
>+  // for the moment
>+  eval(sendMouseEvent.toString().replace("netscape.security.PrivilegeManager.enablePrivilege(\"UniversalBrowserWrite\");", ""));
>   sendMouseEvent({type: "click"}, "root", content);
>+
>   return assistant._open;
> });

This seems a bit fragile. It'll break if that line changes at all in EventUtils.js (but at least it will break in an obvious way).

Maybe instead we should just just createEvent/initMouseEvent/dispatchEvent directly, instead of sendMouseEvent?  Or we could modify EventUtils to add an argument?  I'll let you decide if you want to change this or keep it.
Attachment #500205 - Flags: review?(mbrubeck) → review+
http://hg.mozilla.org/mobile-browser/rev/b76f1542e2bb

I've pushed with a copied version of sendMouseEvent, using  eval/replace to rewrite function on the fly is fun but probably a bad idea after all.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Marking bug as verified fixed?
bugspam
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.