Closed Bug 621976 Opened 9 years ago Closed 9 years ago

Add mouse motion and Gesture magnify events compress for Qt Port

Categories

(Core Graveyard :: Widget: Qt, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(1 file, 2 obsolete files)

this is available in Gtk part, and need to be done for Qt port, improve event handling and safe CPU.

Similar to this
http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsWindow.cpp#2530
Also it would be useful for Meego netbooks devices with Gtk environment...
Attached patch Simple compress with 0 timer (obsolete) — Splinter Review
This is the only way I found how to compress Qt motion and pinch events...
GTK compress way does not work on Qt.

This help us to avoid too many motion events processing.
Attachment #500905 - Flags: feedback?(roc)
Looks reasonable, but instead of a zero-length timer, it might be simpler and work just as well to use a simple XPCOM event instead ... NS_DispatchToMainThread etc.
1) Use DispatchtoMainThread for filtering.
2) Minor code cleanup.
3) calculate distance touchPoint and center point.
Attachment #500905 - Attachment is obsolete: true
Attachment #503464 - Flags: review?(doug.turner)
Attachment #500905 - Flags: feedback?(roc)
Ups, previous patch  contained wrong changes
Assignee: nobody → romaxa
Attachment #503464 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #503465 - Flags: review?(doug.turner)
Attachment #503464 - Flags: review?(doug.turner)
Comment on attachment 503465 [details] [diff] [review]
Updated, filter motion and pinch events

Wolfgang could you check quickly this patch?
Attachment #503465 - Flags: review?(doug.turner) → review?(mozilla)
Comment on attachment 503465 [details] [diff] [review]
Updated, filter motion and pinch events

looks good to me
Attachment #503465 - Flags: review?(mozilla) → review+
http://hg.mozilla.org/mozilla-central/rev/8c57ddbf4ae2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.