Closed Bug 621986 Opened 14 years ago Closed 14 years ago

fix webgl is-object test

Categories

(Core :: Graphics: CanvasWebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: vlad, Assigned: vlad)

Details

Attachments

(2 files)

Attached patch fixSplinter Review
There's some trickiness in this test, especially with shaders and programs. Deleting a program that's current only flags it for deletion after it's no longer current -- it's still supposed to return "true" from isprogram until that happens. Deleting a shader only actually deletes it after it is no longer attached to any programs. (Actually deleting a program detaches all shaders.) This keeps track of the attachment count, and also uses a normal refptr for the current program (deleting it doesn't remove it from the current state, like the others).
Attachment #500249 - Flags: review?(bjacob) → review+
Attached patch additional patchSplinter Review
this fixes a number of other tests that were checking similar shader/program deletion bits. It applies on top of the previous patch -- turns out that just changing the semantics of what's considered Deleted to take into account pending delete and attachments does the right thing.
Attachment #501122 - Flags: review?(bjacob)
Attachment #501122 - Flags: review?(bjacob) → review+
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: