Tab context menu "Bookmark this group of tabs" doesn't work (Error: addGroupmarkAs is not defined)

RESOLVED FIXED in seamonkey2.1b3

Status

SeaMonkey
Bookmarks & History
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Karsten Düsterloh, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.1b3

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Open several tabs, rightclick on one of them, choose "Bookmark this group of tabs". Nothing happens but an error message on the Error Console:

Error: addGroupmarkAs is not defined
Source File: chrome://navigator/content/navigator.xul
Line: 1

Adding a bookmark group from the Bookmarks menu or Personal Toolbar's Bookmarks button works.

Comment 1

7 years ago
> Error: addGroupmarkAs is not defined
Probably something like:
gBookmarkAllTabsHandler.doCommand();
(Assignee)

Updated

7 years ago
OS: Linux → All
Hardware: x86_64 → All
(Assignee)

Comment 2

7 years ago
Created attachment 511959 [details] [diff] [review]
Fix as suggested v0.1 [Checked in: Comment 5]

Simple fix
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #511959 - Flags: review?(philip.chee)

Comment 3

7 years ago
Comment on attachment 511959 [details] [diff] [review]
Fix as suggested v0.1 [Checked in: Comment 5]

Works. I thought that we might need to use command="Browser:BookmarkAllTabs" but it turns out that the tabs context menu has its own disabled items handler.
Attachment #511959 - Flags: review?(philip.chee) → review+

Comment 4

7 years ago
> Works. I thought that we might need to use command="Browser:BookmarkAllTabs"
> but it turns out that the tabs context menu has its own disabled items handler.

In which case it would probably be simpler to call 
PlacesCommandHook.bookmarkCurrentPages() directly in the onbookmarkgroup=.

r+=me either way.
(Assignee)

Comment 5

7 years ago
Comment on attachment 511959 [details] [diff] [review]
Fix as suggested v0.1 [Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/1514f799efdb
Attachment #511959 - Attachment description: Fix as suggested v0.1 → Fix as suggested v0.1 [Checked in: Comment 5]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2

Updated

7 years ago
Target Milestone: seamonkey2.1b2 → seamonkey2.1b3
You need to log in before you can comment on or make changes to this bug.