622010 - Tab context menu "Bookmark this group of tabs" doesn't work (Error: addGroupmarkAs is not defined)

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Karsten Düsterloh]

Open several tabs, rightclick on one of them, choose "Bookmark this group of tabs". Nothing happens but an error message on the Error Console:

Error: addGroupmarkAs is not defined
Source File: chrome://navigator/content/navigator.xul
Line: 1

Adding a bookmark group from the Bookmarks menu or Personal Toolbar's Bookmarks button works.

Comment 1

[Philip Chee]

> Error: addGroupmarkAs is not defined
Probably something like:
gBookmarkAllTabsHandler.doCommand();

Comment 2

[Ian Neal]

Attachment: Fix as suggested v0.1 [Checked in: Comment 5]

Simple fix

Comment 3

[Philip Chee]

Comment on attachment 511959 [details] [diff] [review]
Fix as suggested v0.1 [Checked in: Comment 5]

Works. I thought that we might need to use command="Browser:BookmarkAllTabs" but it turns out that the tabs context menu has its own disabled items handler.

Comment 4

[Philip Chee]

> Works. I thought that we might need to use command="Browser:BookmarkAllTabs"
> but it turns out that the tabs context menu has its own disabled items handler.

In which case it would probably be simpler to call 
PlacesCommandHook.bookmarkCurrentPages() directly in the onbookmarkgroup=.

r+=me either way.

Comment 5

[Ian Neal]

Comment on attachment 511959 [details] [diff] [review]
Fix as suggested v0.1 [Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/1514f799efdb