622080 - Change group which can moderate quips

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Gervase Markham [:gerv]]

(Follow-up from bug 621879, duped to WONTFIXed bug 147276)

BMO wants to change the group which is allowed to moderate quips. quips.cgi:

     my $approved = (Bugzilla->params->{'quip_list_entry_control'} eq "open")
-                   || Bugzilla->user->in_group('admin') || 0;
+                   || Bugzilla->user->in_group('quips-moderators') || 0;
...
(and two other places in the same file, plus four instances in template/en/default/account/prefs/permissions.html.tmpl)

Please advise on what sort of patch would be acceptable to make this customizable.

Gerv

Comment 1

[Max Kanat-Alexander]

I would simply take a patch that adds bz_quip_moderators as a group.

Comment 2

[Gervase Markham [:gerv]]

dkl: do you feel like doing this particular bit of upstreaming? :-)

Gerv

Comment 3

[David Lawrence [:dkl]]

(In reply to comment #2)
> dkl: do you feel like doing this particular bit of upstreaming? :-)
> 
> Gerv

Sure.

Comment 4

[David Lawrence [:dkl]]

Attachment: Patch to change from admin to bz_quip_moderators (v1)

Change from using the admin group to moderate quips to new bz_quip_moderators group.

Dave

Comment 5

[Max Kanat-Alexander]

Comment on attachment 507628 [details] [diff] [review]
Patch to change from admin to bz_quip_moderators (v1)

r=mkanat by inspection, assuming you tested this.

Comment 6

[David Lawrence [:dkl]]

Thanks Max.

trunk:
Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/ modified quips.cgi
modified Bugzilla/Install.pm
modified docs/en/xml/using.xml
modified template/en/default/admin/params/query.html.tmpl
modified template/en/default/list/quips.html.tmpl                           Committed revision 7686.