Closed Bug 622080 Opened 10 years ago Closed 10 years ago

Change group which can moderate quips

Categories

(Bugzilla :: Bugzilla-General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: gerv, Assigned: dkl)

Details

(Whiteboard: [wanted-bmo][bmo4.0-resolved])

Attachments

(1 file)

(Follow-up from bug 621879, duped to WONTFIXed bug 147276)

BMO wants to change the group which is allowed to moderate quips. quips.cgi:

     my $approved = (Bugzilla->params->{'quip_list_entry_control'} eq "open")
-                   || Bugzilla->user->in_group('admin') || 0;
+                   || Bugzilla->user->in_group('quips-moderators') || 0;
...
(and two other places in the same file, plus four instances in template/en/default/account/prefs/permissions.html.tmpl)

Please advise on what sort of patch would be acceptable to make this customizable.

Gerv
I would simply take a patch that adds bz_quip_moderators as a group.
dkl: do you feel like doing this particular bit of upstreaming? :-)

Gerv
(In reply to comment #2)
> dkl: do you feel like doing this particular bit of upstreaming? :-)
> 
> Gerv

Sure.
Assignee: general → dkl
Change from using the admin group to moderate quips to new bz_quip_moderators group.

Dave
Attachment #507628 - Flags: review?(mkanat)
Whiteboard: [wanted-bmo]
Severity: normal → enhancement
Target Milestone: --- → Bugzilla 4.2
Comment on attachment 507628 [details] [diff] [review]
Patch to change from admin to bz_quip_moderators (v1)

r=mkanat by inspection, assuming you tested this.
Attachment #507628 - Flags: review?(mkanat) → review+
Flags: approval+
Thanks Max.

trunk:
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/ modified quips.cgi
modified Bugzilla/Install.pm
modified docs/en/xml/using.xml
modified template/en/default/admin/params/query.html.tmpl
modified template/en/default/list/quips.html.tmpl                           Committed revision 7686.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [wanted-bmo] → [wanted-bmo][bmo4.0-resolved]
You need to log in before you can comment on or make changes to this bug.