622131 - Motorola DROID2 and DROIDX have "Unknown" manufacturer

Status: RESOLVED WONTFIX

(Input :: General, defect, P2)

Description

[Matt Brubeck (:mbrubeck)]

These devices don't show up when "manufacturer=Motorola" is checked, and when you filter for these devices the manufacturer is "Unknown":

http://input.mozilla.com/en-US/search/?q=&product=mobile&version=&date_start=&date_end=&device=DROID2

On IRC, aakashd says this is because these phones report the manufacturer as lowercase "motorola" instead of capitalized "Motorola".

Comment 1

[Aakash Desai [:aakashd]]

Fred, seems like a small enough fix (i.e. make input case-insensitive when siphoning device type and manufacturer from the db) to put in a 2.3 next week or so. What do you think?

Comment 2

[Fred Wenzel [:wenzel]]

Yes, the device/manufacturer names should be case-insensitive. Should consult with davedash on how to teach that to Sphinx -- perhaps we should just index all lowercase and then send the queries to sphinx all lowercase too.

We also got a bigger variety of devices than before now in the database (some bogus). That plays into bug 620760.

Comment 3

[Aakash Desai [:aakashd]]

=(In reply to comment #2)
perhaps we should just index
> all lowercase and then send the queries to sphinx all lowercase too.

That's a viable solution, but won't be very pretty if it stays lowercase once its seen by a user. What about capitalizing at the end?

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

(In reply to comment #3)
> =(In reply to comment #2)
> perhaps we should just index
> > all lowercase and then send the queries to sphinx all lowercase too.
> 
> That's a viable solution, but won't be very pretty if it stays lowercase once
> its seen by a user. What about capitalizing at the end?

We'll normalize all input and also store prettified versions in a lookup table.  No worries.

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Matt/Aakash,

Can I get a Droid2/DroidX to test?  And will these fields auto-fill if I just go to input by manually typing the URL (I want to go to a test version of the Input site).

Not needed for this, but might make solving this easier.

Comment 6

[Matt Brubeck (:mbrubeck)]

(In reply to comment #5)
> Can I get a Droid2/DroidX to test?

There should be some in Mountain View you can borrow if you talk to Aakash or the other mobile team members there.

> And will these fields auto-fill if I just go to input by manually
> typing the URL (I want to go to a test version of the Input site).

To get these to auto-fill on a different site, go to about:config and change these preferences:
extensions.feedback.url.happy
extensions.feedback.url.sad

then use the "Beta Tester Tools" pane in a Fennec Aurora build to submit feedback.

Comment 7

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Moving to Future, but many of these will land in 4.x

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

I think this isn't relevant anymore with the new Input.