Closed Bug 622142 Opened 11 years ago Closed 11 years ago

nsTArray class depends on invalid unqualified lookup into dependent bases of class templates

Categories

(Core :: XPCOM, defect)

x86_64
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b10

People

(Reporter: espindola, Assigned: espindola)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Add "this->" (obsolete) — Splinter Review
xpcom/glue/nsTArray.h expects to be able to access dependent base classes members without adding a this->prefix.

The issue is explained in http://clang.llvm.org/compatibility.html#c++
Blocks: clang-macosx
Hardware: x86 → x86_64
The reporter's summary and initial comment were both lame. I'm merely adjusting the summary and providing a better link. I am not passing judgement on the quality of the bug report.

http://clang.llvm.org/compatibility.html#dep_lookup_bases
Summary: Depends on invalid unqualified lookup into dependent bases of class templates → nsTArray class depends on invalid unqualified lookup into dependent bases of class templates
Duplicate of this bug: 623127
Attachment #500366 - Attachment is obsolete: true
Attachment #500366 - Flags: review?(benjamin)
Attachment #501421 - Flags: review?(benjamin)
Attachment #501421 - Flags: review+
Attachment #501421 - Flags: approval2.0+
Assignee: nobody → respindola
http://hg.mozilla.org/mozilla-central/rev/e4c5d72fca11
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10
You need to log in before you can comment on or make changes to this bug.