Closed
Bug 622142
Opened 14 years ago
Closed 14 years ago
nsTArray class depends on invalid unqualified lookup into dependent bases of class templates
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b10
People
(Reporter: espindola, Assigned: espindola)
References
Details
Attachments
(1 file, 1 obsolete file)
|
7.15 KB,
patch
|
benjamin
:
review+
benjamin
:
approval2.0+
|
Details | Diff | Splinter Review |
xpcom/glue/nsTArray.h expects to be able to access dependent base classes members without adding a this->prefix.
The issue is explained in http://clang.llvm.org/compatibility.html#c++
|
Assignee | |
Updated•14 years ago
|
Blocks: clang-macosx
Hardware: x86 → x86_64
|
|
Assignee | |
Updated•14 years ago
|
Attachment #500366 -
Attachment is patch: true
|
|
Assignee | |
Updated•14 years ago
|
Attachment #500366 -
Flags: review?(benjamin)
The reporter's summary and initial comment were both lame. I'm merely adjusting the summary and providing a better link. I am not passing judgement on the quality of the bug report.
http://clang.llvm.org/compatibility.html#dep_lookup_bases
Summary: Depends on invalid unqualified lookup into dependent bases of class templates → nsTArray class depends on invalid unqualified lookup into dependent bases of class templates
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #500366 -
Attachment is obsolete: true
Attachment #500366 -
Flags: review?(benjamin)
|
|
Assignee | |
Updated•14 years ago
|
Attachment #501421 -
Flags: review?(benjamin)
|
||
Updated•14 years ago
|
Attachment #501421 -
Flags: review?(benjamin)
Attachment #501421 -
Flags: review+
Attachment #501421 -
Flags: approval2.0+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Updated•14 years ago
|
Assignee: nobody → respindola
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10
You need to log in
before you can comment on or make changes to this bug.
Description
•