622144 - code must include string.h to use memset

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: add include

js/src/jsutil.h using memset but doesn't include string.h. The attached patch fixes it.

Comment 1

[David Mandelin [:dmandelin]]

A couple notes:

- You want this "This is patch" checked for the attachment. I already did that for you.

- In the future, you also want 8 lines of context instead of the default 3. For that, see https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_customize_the_format_of_the_patches_Mercurial_creates.3f

Comment 2

[(no longer active)]

This needs approval before it can land on mozilla-central.

Comment 3

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Ping on the approval2.0?

Comment 4

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/e8753473cdff

Thanks for the patch!

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/e8753473cdff