Closed Bug 622264 Opened 9 years ago Closed 9 years ago

Try to make synthesizeDrop works in more situations

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla2.0b11

People

(Reporter: mounir, Assigned: mounir)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
I tried to simulate a drag and drop on a text field with synthesizeDrop. Even if I have finally gave up, I did some improvements to synthesizeDrop to make it works in more general situations.
Ideally, some tests like test_bug603550.html or test_bug508479.html should be able to directly use synthesizeDrop.
Attachment #500515 - Flags: review?(enndeakin)
You'll want to call endDragSession in the early return as well. You could also just use a try-finally block.
Attachment #500515 - Flags: review?(enndeakin) → review-
Attached patch Patch v1.1Splinter Review
Attachment #500515 - Attachment is obsolete: true
Attachment #505423 - Flags: review?(enndeakin)
Attachment #505423 - Flags: review?(enndeakin) → review+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/fa9b50ad86a6

Thanks for the review Neil.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b10
Blocks: 628625
Target Milestone: mozilla2.0b10 → mozilla2.0b11
You need to log in before you can comment on or make changes to this bug.