Closed Bug 622422 Opened 9 years ago Closed 9 years ago

Allow initial pageshow event to complete before firing UIReadyDelayed event

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We are firing the UIReadyDelayed from inside a pageshow event handler. I think we should let the pageshow event handler complete before firing off a new event, which could block or semi-block the main process.

This patch uses setTimeout(..., 0) to let the pageshow event handler complete before firing the UIReadyDelayed event.
Attachment #500692 - Flags: review?(mbrubeck)
Attachment #500692 - Flags: review?(mbrubeck) → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/fb8b399324f4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
mark, is there anything the user needs to see here to verify this?  Also, do we have unit tests?
(In reply to comment #2)
> mark, is there anything the user needs to see here to verify this?  Also, do we
> have unit tests?

Nope, this is all internal. Our browser-chrome tests relay on this working, so they would break if this fails.
So this can be marked as verified fixed, right?
bugspam
Assignee: nobody → mark.finkle
Due to comment #3, I'll mark this bug as verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.