622422 - Allow initial pageshow event to complete before firing UIReadyDelayed event

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

We are firing the UIReadyDelayed from inside a pageshow event handler. I think we should let the pageshow event handler complete before firing off a new event, which could block or semi-block the main process.

This patch uses setTimeout(..., 0) to let the pageshow event handler complete before firing the UIReadyDelayed event.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/fb8b399324f4

Comment 2

[Tony Chung [:tchung]]

mark, is there anything the user needs to see here to verify this?  Also, do we have unit tests?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #2)
> mark, is there anything the user needs to see here to verify this?  Also, do we
> have unit tests?

Nope, this is all internal. Our browser-chrome tests relay on this working, so they would break if this fails.

Comment 4

[Andreea Pod]

So this can be marked as verified fixed, right?

Comment 5

[Dão Gottwald [::dao]]

bugspam

Comment 6

[Cristian Nicolae (:xti)]

Due to comment #3, I'll mark this bug as verified fixed.