622461 - CSS3 transition delay ignored when transition duration is 0

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Daniel Gredler]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0b8) Gecko/20100101 Firefox/4.0b8
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0b8) Gecko/20100101 Firefox/4.0b8

It's valid to specify that a certain property doesn't animate (transition duration = 0) but does wait to take effect (transition delay > 0). Chrome handles this fine; the workaround right now in Firefox is to set the transition duration to a very small number (e.g. 0.01s). See the attached test page for an example. This is somewhat related to bug 533352, except that this bug is about animatable properties, and bug 533352 is about non-animatable properties.

Reproducible: Always

Steps to Reproduce:
Load the attached file.
Actual Results:  
The background color of the test div immediately changes to red, and its height grows for 1 second.

Expected Results:  
The test div's height grows for 1 second, and after it has finished growing then the background color changes to red.

Comment 1

[Daniel Gredler]

Attachment: testcase

Attaching testcase.

Comment 2

[Ed Morley [:emorley]]

Confirmed with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110102 Firefox/4.0b9pre ID:20110102030355

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think this used to work, and I just got a small piece of code in ElementPropertyTransition::ValuePortionFor backwards when refactoring it.  Patch coming in a bit, once I test it.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Patch works:
http://hg.mozilla.org/users/dbaron_mozilla.com/patches/raw-file/820f579b094e/zero-duration-transitions
but I still need to write an automated test, which I'll do later.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I confirmed that a bunch of the new tests fail without the patch, but they all pass with the patch.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 500825 [details] [diff] [review]
patch

r=me

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/66096f867849