622647 - mozJSComponentLoader.cpp:351: warning: ‘nsresult ReadScriptFromStream(JSContext*, nsIObjectInputStream*, JSScript**)’ defined but not used (and same with WriteScriptToStream)

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Daniel Holbert [:dholbert]]

When building mozJSComponentLoader.cpp in a non-libxul build, I get:
../../../../../mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp:351: warning: ‘nsresult ReadScriptFromStream(JSContext*, nsIObjectInputStream*, JSScript**)’ defined but not used
../../../../../mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp:411: warning: ‘nsresult WriteScriptToStream(JSContext*, JSScript*, nsIObjectOutputStream*)’ defined but not used

These functions are only used once, and their only use is guarded with
 #ifdef MOZ_ENABLE_LIBXUL
ever since this cset:
 http://hg.mozilla.org/mozilla-central/diff/fa2993d88825/js/src/xpconnect/loader/mozJSComponentLoader.cpp#l1.278

Since these static methods are only used in libxul builds, they only need to be defined in libxul builds.  Trivial patch coming up to just guard the definitions with MOZ_ENABLE_LIBXUL (fixing the build warning).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: trivial fix

Comment 2

[[e-mail]]

Comment on attachment 500873 [details] [diff] [review]
trivial fix

r=dwitte!

Comment 3

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/tracemonkey/rev/2215b740bca4

Comment 4

[Robert Sayre]

I backed this out because of tinderbox failures.

Comment 5

[Daniel Holbert [:dholbert]]

Re-landed: http://hg.mozilla.org/tracemonkey/rev/294ea1c399f9

(Note that Comment 4 was part of a mass backout -- this particular checkin was almost certainly not responsible for the tinderbox failures)

Comment 6

[Daniel Holbert [:dholbert]]

This landed on mozilla-central as part of a tracemonkey merge a few weeks ago:
   http://hg.mozilla.org/mozilla-central/rev/294ea1c399f9

Closing.