Closed
Bug 622665
Opened 13 years ago
Closed 13 years ago
Remove old unused na2 import code
Categories
(MailNews Core :: Import, defect)
MailNews Core
Import
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.3a2
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
29.54 KB,
patch
|
Bienvenu
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
I found some old na2 import code the other day. We never hooked it up to import, so we should just remove it, this additionally simplifies some of the interfaces (because we no longer need to worry about if addresses are home or work based) and means we can drop some strings.
Attachment #500884 -
Flags: superreview?(neil)
Attachment #500884 -
Flags: review?(bienvenu)
Comment 1•13 years ago
|
||
Comment on attachment 500884 [details] [diff] [review] The fix >- return mailInterface.BeginImport( success, error, false) ? true : false; >+ return mailInterface.BeginImport(success, error) ? true : false; >+ if (addInterface.BeginImport(success, error)) >+ return true; >+ return false; Nit: since BeginImport is already boolean, no need to use if or ?: on them.
Attachment #500884 -
Flags: superreview?(neil) → superreview+
Updated•13 years ago
|
Attachment #500884 -
Flags: review?(bienvenu) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Checked in with comment addressed: http://hg.mozilla.org/comm-central/rev/12ea69f572c6
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2
You need to log in
before you can comment on or make changes to this bug.
Description
•