Closed Bug 622665 Opened 14 years ago Closed 14 years ago

Remove old unused na2 import code

Categories

(MailNews Core :: Import, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a2

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
I found some old na2 import code the other day. We never hooked it up to import, so we should just remove it, this additionally simplifies some of the interfaces (because we no longer need to worry about if addresses are home or work based) and means we can drop some strings.
Attachment #500884 - Flags: superreview?(neil)
Attachment #500884 - Flags: review?(bienvenu)
Comment on attachment 500884 [details] [diff] [review]
The fix

>-    return mailInterface.BeginImport( success, error, false) ? true : false;
>+    return mailInterface.BeginImport(success, error) ? true : false;

>+    if (addInterface.BeginImport(success, error))
>+      return true;
>+    return false;

Nit: since BeginImport is already boolean, no need to use if or ?: on them.
Attachment #500884 - Flags: superreview?(neil) → superreview+
Attachment #500884 - Flags: review?(bienvenu) → review+
Checked in with comment addressed: http://hg.mozilla.org/comm-central/rev/12ea69f572c6
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: