Status

()

Core
Memory Allocator
8 years ago
7 years ago

People

(Reporter: (dormant account), Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Created attachment 500941 [details] [diff] [review]
ashmem pagefile for jemalloc

This gets us swap-like behavior on android. I'm sure this isn't the most correct way of turning on pagefile support in jemalloc, but I'm not sure what the proper way is.
Attachment #500941 - Flags: review?(blassey.bugs)

Comment 1

8 years ago
We need some numbers to back up a change like this.  Does it help startup, memory usage, page load times, us getting killed off?  Once we have that, would need review from Jason Evans
(Reporter)

Comment 2

8 years ago
This doesn't help with us getting killed off. If I switch apps, Android seems to use the exact same kill logic with and without this change. However, if I stay in the app it seems to remain alive longer.

I seem to be able to load more stuff into my fennec before plugin-container starts crashing.

I can load about:memory + firefox tinderbox into 2 tabs. Then plugin-container crashes when I load a 3rd tinderbox.

Without this patch plugin-container dies while loading the second tinderbox.

I'll do some more analysis tomorrow.
Comment on attachment 500941 [details] [diff] [review]
ashmem pagefile for jemalloc

> #ifdef MALLOC_PAGEFILE
>-static bool	opt_pagefile = false;
>+static bool	opt_pagefile = true;
> #endif

You want to add a #ifdef MOZ_MEMORY_ANDROID here, because otherwise, you change the default behaviour on non OSX unices, which do have optional pagefile support.
Comment on attachment 500941 [details] [diff] [review]
ashmem pagefile for jemalloc

I haven't heard that this helps anything, clearing the review request
Attachment #500941 - Flags: review?(blassey.bugs)
You need to log in before you can comment on or make changes to this bug.