Closed Bug 622797 Opened 9 years ago Closed 9 years ago

#ifndef does not work for config/system-headers config

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(1 file)

http://hg.mozilla.org/mozilla-central/annotate/7f2b60765d01/config/system-headers#l1045

This is not recognized correctly by sys config build scripts
Need approval, npodb
Assignee: nobody → romaxa
Attachment #500993 - Flags: review?(ted.mielczarek)
Attachment #500993 - Flags: approval2.0?
Attachment #500993 - Flags: approval2.0?
Attachment #500993 - Flags: review?(ted.mielczarek) → review?(mitchell.field)
Attachment #500993 - Flags: review?(mitchell.field) → review+
Comment on attachment 500993 [details] [diff] [review]
change ifndef to if != 1 system headers

Practically this is npodb... but would be nice to get an approval.
Attachment #500993 - Flags: approval2.0?
Comment on attachment 500993 [details] [diff] [review]
change ifndef to if != 1 system headers

--with-system-pixman npodb, no approval needed
Attachment #500993 - Flags: approval2.0?
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/093fd2087823
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.