Closed
Bug 622797
Opened 14 years ago
Closed 14 years ago
#ifndef does not work for config/system-headers config
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: romaxa, Assigned: romaxa)
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
Mitch
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/annotate/7f2b60765d01/config/system-headers#l1045
This is not recognized correctly by sys config build scripts
|
Assignee | |
Comment 1•14 years ago
|
||
Need approval, npodb
Assignee: nobody → romaxa
Attachment #500993 -
Flags: review?(ted.mielczarek)
Attachment #500993 -
Flags: approval2.0?
|
||
Updated•14 years ago
|
Attachment #500993 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #500993 -
Flags: review?(ted.mielczarek) → review?(mitchell.field)
|
||
Updated•14 years ago
|
Attachment #500993 -
Flags: review?(mitchell.field) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 500993 [details] [diff] [review]
change ifndef to if != 1 system headers
Practically this is npodb... but would be nice to get an approval.
Attachment #500993 -
Flags: approval2.0?
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 500993 [details] [diff] [review]
change ifndef to if != 1 system headers
--with-system-pixman npodb, no approval needed
Attachment #500993 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•14 years ago
|
||
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•