622979 - Update android:versionCode in AndroidManifest.xml in branded builds

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aki Sasaki (not active)]

http://hg.mozilla.org/mozilla-central/file/969691cfe40e/embedding/android/AndroidManifest.xml.in#l6

The versionCode needs to be incremented for us to release a same-version (?) org.mozilla.firefox to the Android Market.

Per IRC around 4.0b3 build 3, Stuart and I prefer to have this actually not be an incremented integer, but some variable (env ANDROIDVERSIONCODE ?) that defaults to buildid if not set.  Buildid should take care of ordinary cases; overriding via that variable will allow us to work around any extraordinary cases.

I'm not entirely sure if this needs to be incremented when we're pushing a new version, but it would probably be safest to have this in place before beta 4.

Comment 1

[Aki Sasaki (not active)]

Also, I'm stating "in branded builds", but it probably won't hurt to set this to buildid in non-branded builds as well.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #1)
> Also, I'm stating "in branded builds", but it probably won't hurt to set this
> to buildid in non-branded builds as well.

I thought so too, bug buildid is too big to be contained in a 32bit unsigned int. I can check in ANDROID_VERSION_CODE which defaults to 1, but the releng scripts will have to increment and set that for each release build. Or we could truncate it to YYYYMMDDHH. Assuming we don't spin more than one release build in an hour that should work, any objections?

Comment 3

[Aki Sasaki (not active)]

I think YYYYMMDDHH will work as a branded default.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

this implements YYYYMMDDHH as a default. It can be over-ridden by setting ANDROID_VERSION_CODE.

Comment 5

[Doug Turner (:dougt)]

is it better to just have a MOZ_BUILD_DATE exported?

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #5)
> is it better to just have a MOZ_BUILD_DATE exported?

I don't think it matters, it's only used twice on any given platform

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/f3bf1a5c419a

Comment 8

[Andreea Pod]

Is there a way for us to verify this?

Comment 9

[Matt Brubeck (:mbrubeck)]

Verified by inspecting the source code.