GCHiddenPointer doesn't need to hide its copy ctor

VERIFIED WONTFIX

Status

VERIFIED WONTFIX
8 years ago
8 years ago

People

(Reporter: stejohns, Assigned: stejohns)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Just what it says -- it does so presumably out of copy-n-paste from other smart-pointerish classes, but there's no justification for it, and blocking it prevents a use in Flash that will be handy. (Yes, GCHiddenPointer is kinda evil and deprecated, but until it's actually slated for demolition, we might as well make it convenient.)
(Assignee)

Comment 1

8 years ago
Created attachment 501188 [details] [diff] [review]
Patch

The magic of "explicit" is probably what we wanted (to avoid temporaries being created)...
Assignee: nobody → stejohns
Attachment #501188 - Flags: superreview?(lhansen)
Attachment #501188 - Flags: review?(treilly)

Comment 2

8 years ago
(In reply to comment #0)
> (Yes, GCHiddenPointer is kinda evil
> and deprecated, but until it's actually slated for demolition, we might as well
> make it convenient.)

That doesn't make sense: if it's evil and deprecated then making it convenient can only make it harder to remove it later.

Comment 3

8 years ago
Comment on attachment 501188 [details] [diff] [review]
Patch

Seems fine although if we're touching player code that's using GCHiddenPointer we should think about removing it or at least creating a player bug with thoughts on how it could be done.
Attachment #501188 - Flags: review?(treilly) → review+
(Assignee)

Comment 4

8 years ago
(In reply to comment #2)
> That doesn't make sense: if it's evil and deprecated then making it convenient
> can only make it harder to remove it later.

Er. Yeah. Guilty as charged.

Comment 5

8 years ago
Comment on attachment 501188 [details] [diff] [review]
Patch

Holding my nose, SR+.
Attachment #501188 - Flags: superreview?(lhansen) → superreview+

Comment 6

8 years ago
Even though I accepted this I bonged Steven's player change that used this so this bug should be closed now I think?
(Assignee)

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WONTFIX

Comment 7

8 years ago
bulk verifying resolved !fixed issues
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.