623116 - Add constructor for nsASCIICaseInsensitiveStringComparator (which inherits from nsStringComparator) to placate CLang

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

nsASCIICaseInsensitiveStringComparator is missing a user defined constructor, but in nsCSSRuleProcessor.cpp a const variable of this type is defined.

This is not valid c++. For more information see "Default initialization of const variable of a class type requires user-defined default constructor" in http://clang.llvm.org/compatibility.html#c++

Comment 1

[timeless]

bugzilla doesn't linkify ++, and your link was poor anyway,

http://clang.llvm.org/compatibility.html#default_init_const

is I believe what you intended to reference.

Comment 2

[timeless]

The reporter's summary and initial comment were both lame. I'm merely adjusting the summary and providing a better link. I am not passing judgement on the quality of the bug report.

http://clang.llvm.org/compatibility.html#default_init_const

Comment 3

[Simon Montagu :smontagu]

I'm far from a C++ language expert, but does that in fact apply? nsASCIICaseInsensitiveStringComparator is non-POD, since it has a base class.

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Sorry for the lameness, but I had to open 13 silly bugs like this and with such an overhead copy and pasting becomes really tempting.

The paragraph in question says:

If no initializer is specified for an object, and the object is of (possibly cv-qualified) non-POD class type (or array thereof), the object shall be default-initialized; if the object is of const-qualified type, the underlying class type shall have a user-declared default constructor. Otherwise, if no initializer is specified for a non-static object, the object and its subobjects, if any, have an indeterminate initial; if the object or any of its subobjects are of const-qualified type, the program is ill-formed.

So i think it applies because it is non-POD.

Comment 5

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

and it was not on windows

Comment 6

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

ping

Comment 7

[İsmail Dönmez]

This patch along with the ones in bug #623123 , #623126 , #628371 also fixes compilation with gcc 4.6 , hats off to espindola, thanks!

Comment 8

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/067fdfe97f0d