623121 - Add constructor for CPPLanguage (which inherits from Language) to placate CLang

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

CPPLanguage is missing a user defined constructor,
but in language.cc a const variable of this type is defined.

This is not valid c++. For more information see "Default initialization of
const variable of a class type requires user-defined default constructor" in
http://clang.llvm.org/compatibility.html#c++

Comment 1

[timeless]

The reporter's summary and initial comment were both lame. I'm merely adjusting the summary and providing a better link. I am not passing judgement on the quality of the bug report.

http://clang.llvm.org/compatibility.html#default_init_const

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 501238 [details] [diff] [review]
patch

Jim wrote all this code.

Comment 3

[Benjamin Smedberg]

Comment on attachment 501238 [details] [diff] [review]
patch

This needs to go upstream to breakpad. I don't want to accept it locally for just a compiler fix.

Comment 4

[(not currently active) Ted Mielczarek]

Yeah, I'm fine with getting r+ on these in bugzilla and pushing them all upstream at once, though, since they're all pretty trivial fixes.

Comment 5

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

so, on whose plate is this? If mine should I send the code for review in breakpad first or finish this review first?

Comment 6

[(not currently active) Ted Mielczarek]

Doesn't really matter, as long as it gets reviewed somewhere. We can land it in both places at the same time. Jim and I are both Breakpad peers, and the Breakpad project isn't really nitpicky about where reviews happen. (The Google devs do reviews in the Chromium review tool all the time.)

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/b0c917ad881b

Comment 8

[(not currently active) Ted Mielczarek]

Landed upstream:
http://code.google.com/p/google-breakpad/source/detail?r=764

Rafael: can you close the Breakpad review issue:
http://breakpad.appspot.com/249001/show ? (Click "Edit Issue" then there's a "Closed" checkbox.) Only the person who created an issue can edit it.