623122 - CurrentThreadId does not have a return for an unreachable exit path (missing return)

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

CurrentThreadId is missing a returns which causes clang to produce a warning that because of -Werror=return-type causes the build to fail.

Comment 1

[timeless]

1959 CurrentThreadId()
1960 {
1961 #if defined(XP_WIN)
1962   return ::GetCurrentThreadId();
1963 #elif defined(XP_LINUX)
1964   return sys_gettid();
1965 #elif defined(XP_MACOSX)
1966   // Just return an index, since Mach ports can't be directly serialized
1967   thread_act_port_array_t   threads_for_task;
1968   mach_msg_type_number_t    thread_count;
1969 
1970   if (task_threads(mach_task_self(), &threads_for_task, &thread_count))
1971     return -1;
1972 
1973   for (unsigned int i = 0; i < thread_count; ++i) {
1974     if (threads_for_task[i] == mach_thread_self())
1975       return i;
1976   }
1977 #else
1978 #  error "Unsupported platform"
1979 #endif
1980 }

It's tempting to suggest abort() is better than return -1.

Comment 2

[(not currently active) Ted Mielczarek]

It kind of sucks either way, certainly, but these functions are incredibly unlikely to fail, so maybe an abort makes sense.

Comment 3

[(not currently active) Ted Mielczarek]

Rafael: FWIW, given how small all these patches are, I would have been fine with them all on one bug, like "fix CLang compilation issues in Breakpad".

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch that uses abort() instead of return 0

Comment 5

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/b17f28507ab4