Closed Bug 623135 Opened 10 years ago Closed 10 years ago

browser_615394-SSWindowState_events.js is not cleaning up after itself

Categories

(Firefox :: Session Restore, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 4.0b10

People

(Reporter: mossop, Assigned: zpao)

References

Details

Attachments

(1 file)

Looking at current browser-chrome test logs I see multiple occurrences of this after the test has finished and others are running:

Console message: [JavaScript Error: "windowObserver is not defined" {file: "chrome://mochitests/content/browser/browser/components/sessionstore/test/browser/browser_615394-SSWindowState_events.js" line: 347}]

Clearly this test isn't properly cleaning itself up and should be fixed to ensure it doesn't cause problems with later tests.
Attached patch Patch v0.1Splinter Review
Luckily that observer isn't actually doing anything or this would have been a problem. It was a typo (or rather I copy+pasted+changed names and forgot to change one name).
Assignee: nobody → paul
Status: NEW → ASSIGNED
Pushed http://hg.mozilla.org/mozilla-central/rev/3cf8c2ab8d3b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
Looks fine in today's logs.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.