623142 - Mozilla.com's Getting Started page uses SUMO's search.php URL

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://www.mozilla.com/en-US/firefox/central/ points its SUMO search widget to search.php (http://support.mozilla.com/en-US/search.php?where=all&locale=en-US&q=instant&x=0&y=0), but it should be doing a search like so:

http://support.mozilla.com/en-US/search?q=instant

I don't know if the solution is to redirect search.php and include the query term, or just to fix Mozilla.com (or both, for other potential consumers/includes).

Comment 1

[James Socol [:jsocol, :james]]

(In reply to comment #0)
> I don't know if the solution is to redirect search.php and include the query
> term, or just to fix Mozilla.com (or both, for other potential
> consumers/includes).

We should fix mozilla.com. We did redirect search.php for several months after the initial switch.

Comment 2

[Steven Garrity [:sgarrity]]

This search form has two hidden fields that are adding the "?where=all&locale=en-US" to the search:

▸   <input type="hidden" name="where" value="all" />
▸   <input type="hidden" name="locale" value="en-US" />

Should both of these remain?

Comment 3

[James Socol [:jsocol, :james]]

(In reply to comment #2)
> ▸   <input type="hidden" name="where" value="all" />

Drop this one.

> ▸   <input type="hidden" name="locale" value="en-US" />

I assume the value depends on the current locale, right? There are a couple of options:

1) Change the name from "locale" to "language." This will make SUMO determine its UI language based on the user's Accept-Language header, but show results in from the specified language.

2) Change the name from "locale" to "lang," which will force the SUMO UI, and results, into whatever value is specified here.

I imagine (2) is closer to the expected behavior.

Comment 4

[Steven Garrity [:sgarrity]]

Fixed in trunk (using method (2) from comment #3) in r80211.

James, look ok? The X and Y vars are a side-effect of the submit button being an image - the browser sends the x/y coords of where an image submit button was clicked.

Comment 5

[James Socol [:jsocol, :james]]

Looks fine to me. The x and y values will be ignored.

Comment 6

[Steven Garrity [:sgarrity]]

Merged to stage in r80212.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

qa-verified-trunk: we're now submitting https://support.mozilla.com/en-US/search?q=instant&y=0&x=0

Comment 8

[James Long (:jlongster)]

Pushed to production

r80672 | [e-mail] | 2011-01-12 17:16:20 -0500 (Wed, 12 Jan 2011) | 5 lines

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on prod.