Open Bug 623196 Opened 12 years ago Updated 2 months ago

mochitests-4: test_parse_url.html outputs an over-long log line

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
minor

Tracking

()

mozilla2.0b9

People

(Reporter: sgautherie, Unassigned)

References

()

Details

Attachments

(1 file)

http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1294232560.1294233262.28191.gz
Rev3 Fedora 12 tryserver opt test mochitests-4/5 on 2011/01/05 05:02:40
{
22236 ERROR TEST-UNEXPECTED-FAIL | SimpleTest._logResult() | Next log line was cut because its length was too long (106132 > 16384): fix the test!
22237 INFO TEST-PASS | /tests/layout/style/test/test_parse_url.html | very long url not correctly parsed - "url(\"verylongurlindeed_thequi [... ...]
}
(In reply to comment #0)
> http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1294232560.1294233262.28191.gz
> Rev3 Fedora 12 tryserver opt test mochitests-4/5 on 2011/01/05 05:02:40
> {
> 22236 ERROR TEST-UNEXPECTED-FAIL | SimpleTest._logResult() | Next log line was
> cut because its length was too long (106132 > 16384): fix the test!
> 22237 INFO TEST-PASS | /tests/layout/style/test/test_parse_url.html | very long
> url not correctly parsed - "url(\"verylongurlindeed_thequi [... ...]
> }

This is not a useful first comment of a bug.

What you should have said is:

I'm working on capping the line length of mochitest output because of [...].  This patch fixes test_parse_url.html to avoid exceeding that limit.
Comment on attachment 501306 [details] [diff] [review]
(Av1) Stop generating a 108 KiB log line

The new test isn't equivalent, and it's an entirely reasonable thing to test.  Our test harness should handle it correctly.
Attachment #501306 - Flags: review?(dbaron) → review-
(In reply to comment #2)
> This is not a useful first comment of a bug.
> What you should have said is:
> I'm working on capping the line length of mochitest output because of [...]. 
> This patch fixes test_parse_url.html to avoid exceeding that limit.

'[...]' is bug 621390: I assumed the error message and the dependency would be explicit enough :-|


(In reply to comment #3)

> The new test isn't equivalent, and it's an entirely reasonable thing to test. 

What isn't equivalent exactly?
(I'll fix that as much as possible.)
What does your "it" refer to exactly?

> Our test harness should handle it correctly.

Please, comment on bug 621390.
NB: this patch is similar to those that have already been reviewed positively...

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Assignee: bugzillamozillaorg_serge_20140323 → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.