Need Test for HTTP Syn Retry Race Condition

RESOLVED DUPLICATE of bug 623948

Status

()

defect
RESOLVED DUPLICATE of bug 623948
8 years ago
7 years ago

People

(Reporter: mcmanus, Unassigned)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(blocking2.0 -)

Details

Attachments

(1 obsolete attachment)

(Reporter)

Description

8 years ago
bug 613977 showed a hard to reproduce bug that require an ssl connection that is slow enough to trigger a backup connection to be initiated but fast enough to still be completed at a roughly similar time.

It is caught by the mozmill security tests, but I've been asked for something more.. honzab suggests:

"Do you think you could create a test for the patch?  I could go one of the ways (up to you to go your own of course):
- have a binary test for just this particular patch; you need to manage call to PR_Accept or a listening socket being up/down; the letter may also be done in JS with server socket component
- have a new binary inserted as a transparent proxy to the testing chain, we can manage this proxy to accept/throw/delay connection accept; this utility may be later enhanced to also emulate weirdness of some HTTP servers/accelerators to test the pipelining blacklisting or whatever more we want
- enhance e.g. SSL tunnel, or generalize it/branch it, to support what the previous point suggests..."
(Reporter)

Updated

8 years ago
blocking2.0: --- → ?
Depends on: 613977
Please confirm as a blocker.  If we don't have a test for the HTTP acceleration and its regressions, we should remove all the code or at least disable the preference before final Fx4 release.  The risk/gain ratio is too high here.
jst, jduell, and I talked about this and we all agreed with Honza that there is too much risk for the feature and that it should be turned off or disabled (AFAICT, regardless of the existence of tests).
(Reporter)

Comment 3

8 years ago
I don't support the removal of this feature, but if you want to do it this is the patch to make it happen.
Attachment #501534 - Flags: review?(honzab.moz)
(Reporter)

Updated

8 years ago
Attachment #501534 - Attachment is obsolete: true
Attachment #501534 - Flags: review?(honzab.moz)
(Reporter)

Comment 4

8 years ago
bundle the test requirement into the "reland syn retry after ff 4.0" bug 623948
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 623948
blocking2.0: ? → -
You need to log in before you can comment on or make changes to this bug.