623211 - Add-ons manager add-on author name and link should be removed from list view

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Jennifer Morrow [:Boriss] (UX)]

Attachment: Mockup: removal of authors' names from list view in add-ons manager

In the process of simplifying the design of the add-ons manager, keeping only what information is useful for providing an overview of installed add-ons is an important goal for the streamlined design of list view.

While giving an author's name and information is important, this information does not serve the overview-only purpose of list view.  By moving the add-on author to description view, we also group it with other relevant information: the author's homepage, the author's AMO profile, and a link to donate to author.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: patch

This patch applies on top of my patch in bug 623207. I've had to adjust the theme to achieve the space savings.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 503767 [details] [diff] [review]
patch

Please remove the elements from the XBL and update the tests so they don't fail.

Comment 3

[Matthew Printz [:hipokrit]]

Attachment: Patch to remove element from XBL and update tests per review of

Got goahead from Geoff to put this patch together.

I kept Geoff's changes to the theme to allow space saving.

Comment 4

[Dave Townsend [:mossop]]

Is this patch ready for review?

Comment 5

[Matthew Printz [:hipokrit]]

Sorry it didn't get marked. Patch is ready for review.

Comment 6

[Dave Townsend [:mossop]]

What does this look like with the style changes, I'm a bit worried that the icon will not be placed right.

Comment 7

[Matthew Printz [:hipokrit]]

Attachment: Screenshot showing placement

Comment 8

[Jennifer Morrow [:Boriss] (UX)]

(In reply to comment #7)
> Created attachment 506904 [details]
> Screenshot showing placement

Those icons really want to move down 8pixels to be centered vertically with the row.

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 506850 [details] [diff] [review]
Patch to remove element from XBL and update tests per review of

Get the icon spacing right but otherwise this looks good.

Comment 10

[Matthew Printz [:hipokrit]]

Attachment: Revised patch w/CSS change

This moves the icons down 8 pixels per Boriss' review.

Comment 11

[Matthew Printz [:hipokrit]]

Attachment: New screenshot

Screenshot showing positioning with patch 507121.

Comment 12

[Dave Townsend [:mossop]]

Comment on attachment 507121 [details] [diff] [review]
Revised patch w/CSS change

Looks good to me, thanks

Comment 13

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/2d3c0374a0f9

Comment 14

[Siddhartha Dugar [:sdrocking]]

Attachment: Larger icon causes height to increase

Notice the increased height of the entry for Check Places add-on. This looks odd.

Comment 15

[Matthew Printz [:hipokrit]]

Attachment: Patch to fix positioning/sizing

Instead of using margins to get close to centering, this patch lets XUL figure out how to center and allows icons up to the max size of 48px to be displayed without resizing the addon list item.

Comment 16

[Matthew Printz [:hipokrit]]

Attachment: Screenshot showing change in patch 507457

This screenshot shows how the positioning works with the above patch. As you can see, the addon item for Check Places is the same size, even though the icon is larger. Also, the icons are now perfectly centered regardless of size.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 507457 [details] [diff] [review]
Patch to fix positioning/sizing

Thanks for the patch. Lets ask for review from Dave.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Reopening until the remaining issue has been solved. At best it would have been a separate bug.

Comment 19

[Dave Townsend [:mossop]]

Comment on attachment 507457 [details] [diff] [review]
Patch to fix positioning/sizing

Looks like this will cause bug 603057 again so I don't think it is the right solution. Regardless please open a new bug for the remaining issue

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b11pre) Gecko/20110127 Firefox/4.0b11pre. Nothing to test here.