Closed Bug 623211 Opened 12 years ago Closed 12 years ago

Add-ons manager add-on author name and link should be removed from list view


(Toolkit :: Add-ons Manager, defect)

Not set



Tracking Status
blocking2.0 --- final+


(Reporter: jboriss, Assigned: hipokrit)



(Keywords: polish, Whiteboard: [softblocker])


(7 files, 2 obsolete files)

In the process of simplifying the design of the add-ons manager, keeping only what information is useful for providing an overview of installed add-ons is an important goal for the streamlined design of list view.

While giving an author's name and information is important, this information does not serve the overview-only purpose of list view.  By moving the add-on author to description view, we also group it with other relevant information: the author's homepage, the author's AMO profile, and a link to donate to author.
Keywords: meta
Blocks: 623250
Assignee: bmcbride → nobody
Keywords: polish, uiwanted
blocking2.0: --- → ?
Whiteboard: [softblocker]
blocking2.0: ? → final+
Assignee: nobody → geoff
Attached patch patchSplinter Review
This patch applies on top of my patch in bug 623207. I've had to adjust the theme to achieve the space savings.
Attachment #503767 - Flags: review?(dtownsend)
Comment on attachment 503767 [details] [diff] [review]

Please remove the elements from the XBL and update the tests so they don't fail.
Attachment #503767 - Flags: review?(dtownsend) → review-
Keywords: uiwanted
Got goahead from Geoff to put this patch together.

I kept Geoff's changes to the theme to allow space saving.
Is this patch ready for review?
Assignee: geoff → hipokrit
Attachment #506850 - Flags: review?(dtownsend)
Sorry it didn't get marked. Patch is ready for review.
What does this look like with the style changes, I'm a bit worried that the icon will not be placed right.
Attached image Screenshot showing placement (obsolete) —
(In reply to comment #7)
> Created attachment 506904 [details]
> Screenshot showing placement

Those icons really want to move down 8pixels to be centered vertically with the row.
Comment on attachment 506850 [details] [diff] [review]
Patch to remove element from XBL and update tests per review of

Get the icon spacing right but otherwise this looks good.
Attachment #506850 - Flags: review?(dtownsend) → review-
This moves the icons down 8 pixels per Boriss' review.
Attachment #506850 - Attachment is obsolete: true
Attachment #506904 - Attachment is obsolete: true
Attachment #507121 - Flags: review?(dtownsend)
Attached image New screenshot
Screenshot showing positioning with patch 507121.
Comment on attachment 507121 [details] [diff] [review]
Revised patch w/CSS change

Looks good to me, thanks
Attachment #507121 - Flags: review?(dtownsend) → review+
Keywords: checkin-needed
Whiteboard: [softblocker] → [softblocker][has patch][can land]
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [softblocker][has patch][can land] → [softblocker]
Target Milestone: --- → mozilla2.0b11
Notice the increased height of the entry for Check Places add-on. This looks odd.
Instead of using margins to get close to centering, this patch lets XUL figure out how to center and allows icons up to the max size of 48px to be displayed without resizing the addon list item.
Attachment #507457 - Flags: review?
This screenshot shows how the positioning works with the above patch. As you can see, the addon item for Check Places is the same size, even though the icon is larger. Also, the icons are now perfectly centered regardless of size.
Comment on attachment 507457 [details] [diff] [review]
Patch to fix positioning/sizing

Thanks for the patch. Lets ask for review from Dave.
Attachment #507457 - Flags: review? → review?(dtownsend)
Reopening until the remaining issue has been solved. At best it would have been a separate bug.
Resolution: FIXED → ---
Comment on attachment 507457 [details] [diff] [review]
Patch to fix positioning/sizing

Looks like this will cause bug 603057 again so I don't think it is the right solution. Regardless please open a new bug for the remaining issue
Attachment #507457 - Flags: review?(dtownsend) → review-
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b11pre) Gecko/20110127 Firefox/4.0b11pre. Nothing to test here.
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.