623220 - Add-on bar and Find bar close buttons don't line up

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Jürgen Kreileder]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20110104 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20110104 Firefox/4.0b9pre

The close buttons on the add-on and find bars don't appear lined up.  There's a 1 pixel difference.

Reproducible: Always

Comment 1

[Jürgen Kreileder]

Attachment: showing the 1px displacement

Comment 2

[Markus Amalthea Magnuson]

Attachment: Fix left margin on close buttons for find bar and addon bar on Mac.

I am still seeing this on the current nightly.

Attached is a patch that pushes the find bar close button one pixel, and the addon bar close button two pixels, so that both line up their left edge (of the mouseover state, i.e. full button graphic) with the left edge of the window close button and browser back button.

Comment 3

[Markus Amalthea Magnuson]

Attachment: Current un-aligned appearance, and after applying patch.

Here's a screenshot of the current appearance, and the fixed appearance when applying the patch.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 577682 [details] [diff] [review]
Fix left margin on close buttons for find bar and addon bar on Mac.

Thanks!

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e341ef2495af

Comment 6

[Ed Morley [:emorley]]

Meant to add: To save time for future patches, could you set your hgrc to include the author automatically & also add a commit message, along the lines of:
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Thanks :-)

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/e341ef2495af