Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Add-on bar and Find bar close buttons don't line up

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Theme
--
trivial
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: Jürgen Kreileder, Assigned: Markus Amalthea Magnuson)

Tracking

unspecified
Firefox 11
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20110104 Firefox/4.0b9pre
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b9pre) Gecko/20110104 Firefox/4.0b9pre

The close buttons on the add-on and find bars don't appear lined up.  There's a 1 pixel difference.

Reproducible: Always
(Reporter)

Comment 1

7 years ago
Created attachment 501323 [details]
showing the 1px displacement
(Assignee)

Comment 2

6 years ago
Created attachment 577682 [details] [diff] [review]
Fix left margin on close buttons for find bar and addon bar on Mac.

I am still seeing this on the current nightly.

Attached is a patch that pushes the find bar close button one pixel, and the addon bar close button two pixels, so that both line up their left edge (of the mouseover state, i.e. full button graphic) with the left edge of the window close button and browser back button.
Assignee: nobody → markus.magnuson
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #577682 - Flags: review?(dao)
(Assignee)

Comment 3

6 years ago
Created attachment 577683 [details]
Current un-aligned appearance, and after applying patch.

Here's a screenshot of the current appearance, and the fixed appearance when applying the patch.
Comment on attachment 577682 [details] [diff] [review]
Fix left margin on close buttons for find bar and addon bar on Mac.

Thanks!
Attachment #577682 - Flags: review?(dao) → review+

Updated

6 years ago
Keywords: checkin-needed

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e341ef2495af
Keywords: checkin-needed
Target Milestone: --- → Firefox 11

Comment 6

6 years ago
Meant to add: To save time for future patches, could you set your hgrc to include the author automatically & also add a commit message, along the lines of:
https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Thanks :-)
https://hg.mozilla.org/mozilla-central/rev/e341ef2495af
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.