623222 - the update xml for android is pushed out before the actual update

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

The problem is that if anything goes wrong with building or publishing the nightly, users constantly get offered a non-existent update.

Comment 1

[Aki Sasaki (not active)]

Is there an example of this?

For nightlies, we:

a) build en-US
b) create en-US snippets
c) upload en-US
d) upload en-US snippets
e) repeat for multilocale

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

While the multilocale repacks were broken, people were getting notifications that updates were available but the download failed because it wasn't available. I asked bear if we upload the updates.xml before the apk was uploaded, he said they might.

Comment 3

[Aki Sasaki (not active)]

We upload afterwards.
However, it's certainly possible we upload them whether the build was successful or not.  I'll try to see what we can do to avoid that.

Comment 4

[Aki Sasaki (not active)]

I think we need to stop uploading en-US snippets.  Pretty sure AUS doesn't distinguish between the en-US and multi installs.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

What does a query to AUS for a multi-install look like ? An actual captured over the wire example. If it's expanding %LOCALE% as en-US for multi then I'm not surprised this is happening.

Comment 6

[Aki Sasaki (not active)]

Attachment: port android multilocale update fixes from 0.7 to 0.8

* Don't create updates for en-US in a multilocale Android build
* The multi update snippet is uploaded after the apk, which is uploaded with haltOnFailure=True. So if we don't upload the apk successfully, we won't upload the snippet.
* Remove the outdated AndroidReleaseBuildFactory in 0.8.  When we port mobile releases to 0.8 we would have overwritten this; having old unused code is confusing.

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 510395 [details] [diff] [review]
port android multilocale update fixes from 0.7 to 0.8

Tested here:
http://staging-master.build.mozilla.org:8011/builders/Android%20R7%20mozilla-central%20nightly/builds/0

No update steps happened before the multil10n step; looks good.

Comment 8

[Aki Sasaki (not active)]

Comment on attachment 510395 [details] [diff] [review]
port android multilocale update fixes from 0.7 to 0.8

http://hg.mozilla.org/build/buildbotcustom/rev/ab47536b72f7